130 replies to this topic

[newburns]

@ tonyle - I know for a fact, it is not incompatible. I had a similar issue, but I cannot say what I have done to fix it.
List the files you have changed and I may be able to upload my changed files for you. I have gotten it to work in OSC 2.3.3 with a lot of addons and heavily modified store. See list above

[tonyle]

newburns, on 04 March 2013 - 03:05 PM, said:

@ tonyle - I know for a fact, it is not incompatible. I had a similar issue, but I cannot say what I have done to fix it.
List the files you have changed and I may be able to upload my changed files for you. I have gotten it to work in OSC 2.3.3 with a lot of addons and heavily modified store. See list above

@newburns Thanks for the feedback
The OSC 2.3.1 store is pretty much unmodified - I modified all files as per instructions in CCGV 6.0 package using text comparison. Could it just be a question of some whitespace causing the internal server error?

Any way it is reassuring that a  fix is possible. Most bugs will usually give up if you persist long enough!

[newburns]

@tonyle - Try this checkout_confirmation.
I have MATC (Must Accept Terms and Agreements) installed, but this should help give some bearing on whats going on.
Be sure to save your current checkout_confirmation.php
Also, you could do a file compare.
That would be best.
I use Notepad++

Attached Files

•  checkout_confirmation.php   11.99K   6 downloads

Edited by newburns, 04 March 2013 - 06:56 PM.

[SharperJacks]

PayPal Express does not show the discount price.

Is there a fix?

Any feedback is much appreciated.

[robertwhitis]

I'm on 2.3.3.

@omat: I'm also experiencing this issue of the checkout_shipping step being skipped, whether there is a GV/Coupon in the cart or not, just all of a sudden, no shipping page, and if you try to go there directly, you are redirected to checkout_payment. If anyone has a solution for this problem, it would be appreciated!

@MountainMan: I'm also experiencing this issue with the language files not picking up everything, but I simply replaced the calls that weren't working with hard coded text. The two instances you mentioned are the only two instances I have seen.

Also, in the current state, if I go to checkout (it auto skips shipping w/o selecting a method), if I click continue, checkout_confirmation gives me an unexpected end of file PHP error.

I've used a lot of osCommerce and Zen Cart modules in my time, I've followed the directions perfectly, and made sense of most of the mis-information in the directions, but I'm stumped at the moment. If I figure out answers to this shipping skip / end of file error, I'll post my findings.

Edited by robertwhitis, 15 March 2013 - 07:09 PM.

[robertwhitis]

As it turns out, the reason for shipping being skipped is pretty elementary - if you have no products in the cart that are not virtual (e.g. also, check that if a product is not virtual that it has a weight specified) - it will, logically, skip shipping.

It was skipping shipping even with physical products in the cart for me, until I looked at the product and realized it had no shipping weight assigned. Once I assigned a shipping weight to the product in my cart, the shipping page showed up just fine.

Now I am working on the end of file error in checkout_confirmation, and I have just noticed that none of the payment methods installed are showing up on the checkout_payment page, so I'm going to take a wild stab and say that the lack of payment information being provided is the reason for the failure of the checkout_confirmation page.

More updates to come, hopefully.

Edited by robertwhitis, 15 March 2013 - 07:31 PM.

[robertwhitis]

I have just noticed that if you go to the GV FAQ page, and click on "check balance" - or go to the account page and click check balance, the filename linked to does not exist. Also, in the case of the link on the account page, the link is created using a constant which isn't defined (checked filenames.php modify instructions to verify).

So, basically the file, /catalog/gv_balance.php was left off the addon altogether.

If the author has this file, it'd be great to post an updated version that fixes these things.

Also, on the send store credit page, it doesn't display how much store credit you have. So if you want to share your store credit by passing it on to someone else, it'd make sense to display how much you have to share on that page, just a thought.

Off to create my own gv_balance.php file.

Robert

[robertwhitis]

For those that need a gv_balance.php file, I suggest you edit /catalog/includes/filenames.php and add a define for FILENAME_GV_BALANCE, gv_balance.php first.

Here is the code I used:

<?php
/*
  $Id$

  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com

  Copyright (c) 2010 osCommerce

  Released under the GNU General Public License
*/

  require('includes/application_top.php');

  if (!tep_session_is_registered('customer_id')) {
	$navigation->set_snapshot();
	tep_redirect(tep_href_link(FILENAME_LOGIN, '', 'SSL'));
  }

  require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_ACCOUNT);

  $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_ACCOUNT, '', 'SSL'));

  require(DIR_WS_INCLUDES . 'template_top.php');
?>

<h1><?php echo HEADING_TITLE; ?> - Gift Vouchers</h1>

<?php
  if ($messageStack->size('account') > 0) {
	echo $messageStack->output('account');
  }
?>

<div class="contentContainer">
  <b>Gift Voucher Balance</b>

  <div class="contentText">
  <?php
//CCGV BEGIN
  if (tep_session_is_registered('customer_id')) {
		$gv_query = tep_db_query("select amount from " . TABLE_COUPON_GV_CUSTOMER . " where customer_id = '" . $customer_id . "'");
		$gv_result = tep_db_fetch_array($gv_query);

?>
		   <div class="contentText">
		<ul class="accountLinkList">
		  <li><span class="ui-icon ui-icon-star accountLinkListEntry"></span><?php echo 'Gift Voucher Balance: '; ?>
  <?php echo $currencies->format($gv_result['amount']); ?></li>
</ul>
<ul class="accountLinkList">
		  <li><span class="ui-icon ui-icon-mail-closed accountLinkListEntry"></span><?php echo '<a href="' . tep_href_link(FILENAME_GV_SEND, '', 'SSL') . '">' . 'Share Gift Voucher' . '</a>'; ?></li>
</ul>
<ul class="accountLinkList">
		  <li><span class="ui-icon ui-icon-help accountLinkListEntry"></span><?php echo '<a href="' . tep_href_link(FILENAME_GV_FAQ, '', 'SSL') . '">' . 'Gift Voucher FAQ' . '</a>'; ?></li>
		</ul>
  </div>
<?php

  }
// CCGV END
?>
  </div>

</div>

<div style="clear: both;"></div>

<?php
  require(DIR_WS_INCLUDES . 'template_bottom.php');
  require(DIR_WS_INCLUDES . 'application_bottom.php');
?>

Don't hang me out to dry for putting each "li" it's own "ul"...for some reason, it was indenting each "li" further and further, didn't feel like spending any time figuring out why, so there's a little extra spacing between each "li" - no biggie.

Robert

Edited by robertwhitis, 31 March 2013 - 08:04 PM.

[newburns]

@robertwhitis How do I add a link to the account.php to check the balance using gv_balance.php?

[newburns]

deleting an order does not return credit amount similar to returning an item to stock

[Comesticage]

robertwhitis, on 15 March 2013 - 07:22 PM, said:

As it turns out, the reason for shipping being skipped is pretty elementary - if you have no products in the cart that are not virtual (e.g. also, check that if a product is not virtual that it has a weight specified) - it will, logically, skip shipping.

It was skipping shipping even with physical products in the cart for me, until I looked at the product and realized it had no shipping weight assigned. Once I assigned a shipping weight to the product in my cart, the shipping page showed up just fine.

Now I am working on the end of file error in checkout_confirmation, and I have just noticed that none of the payment methods installed are showing up on the checkout_payment page, so I'm going to take a wild stab and say that the lack of payment information being provided is the reason for the failure of the checkout_confirmation page.

More updates to come, hopefully.

Hey Robert, i spent hours on saturday trying to find out why it skipped the shipping page and in the end, i had to restore everything..

This morning i woke up, read your post - about the shipping weight - THEN i dive in and redo everything!

It works! I believe now my site is live with the discount coupon as well as store credits!

Thanks a million!