16 replies to this topic

[goodnews]

Hi there,

As anyone seen or used a templet from www.templetworld.com?

If so, was it OK or did you find problums?

Look forward to your reply...John

[kymation]

I have looked at a couple of their "templates." They are not true templates; they are modified copies of osCommerce. Worse, they are modified from osC version 2.2MS2. This is outdated and unsafe code. I have no idea if the templates have been patched to fix all of the bugs and security vulnerabilities in this old software. It's not worth my time to do so.

Note that I have only seen two of these templates. There may be others that are up to date, and they may have fixed the ones I saw after I looked at them. Are you willing to gamble on this?

My recommendation: Run away. Fast.

Regards
Jim

[goodnews]

kymation, on 18 April 2011, 00:14, said:

I have looked at a couple of their "templates." They are not true templates; they are modified copies of osCommerce. Worse, they are modified from osC version 2.2MS2. This is outdated and unsafe code. I have no idea if the templates have been patched to fix all of the bugs and security vulnerabilities in this old software. It's not worth my time to do so.

Note that I have only seen two of these templates. There may be others that are up to date, and they may have fixed the ones I saw after I looked at them. Are you willing to gamble on this?

My recommendation: Run away. Fast.

Regards
Jim

Hi Jim

Thanks for taking the time to view these templets, but how did you find out that they were modified copies of osCommerce and modified from osC version 2.2MS2?

I would love to know how to do this for the futher, I also think this is something that we all could do with learning so we can spot the bad templets that are flying around the Internet...John

[kymation]

Just look at what is supplied with this "template." It helps to be familiar with the standard osCommerce code. In the case of the templates that I looked at, both contained a compete set of osCommerce files.

A good comparison program can help spot the differences in the individual files. Comparing the files in the template with stock osC files, I found that they matched the 2.2MS2 files, with the exception of changes made to support the cosmetic changes the template created. As I said, I didn't check for updates to the original 2.2 MS2 code. The templates may have actually been a later version with some of the bug fixes and security fixes added in. I didn't take the time to find out. I did verify that they did not have files from 2.2rc1 or later, so they are older than that.

One further issue: Since these files are copies of osCommerce files, they are licensed under the GPL and thus freely redistributable. The only copyrighted material that you are buying is the images. So, when you evaluate these templates, consider whether the images alone are worth the cost. If not, check the Addons section for code that will make similar changes to the page code. The changes that the template makes are usually just taken from free Addons, sometimes with some minor changes in the page format. It's rare to see a template that makes major changes. Templates are usually coded as simply as possible to maximize the profit from selling the package.

Regards
Jim

[ozstar]

HI,

I have just bought a template from them.

It says that it uses OsCommerce 2.2 RC2a.

I am about to update it to 2.3, hopefully it will not be a problem.

oz

[kymation]

Can you tell us the template number? I'd like to know if it's one that I've looked at.

Regards
Jim

[ozstar]

Hi Jim,

It is 25877.

I have just loaded it onto my PC wamp 2.1e and get quite a few ..

'Depreciated ereg functions' as it is running php5.3

I am now looking for a definitive instruction on updating those.

Othet than that catalog and admin seem to look okay at least.

Let me know what you see please.

Regards,

oz

[kymation]

That's not one that I have looked at.

There is a thread on the forum with the changes to comply with PHP 5.3. It shouldn't be too hard to find.

Regards
Jim

[DunWeb]

You can also use this:

http://addons.oscommerce.com/info/7394



Chris

[ozstar]

Hi,

Thanks for the answer.

I have made the changes and have checked them but now get these messages...

Under the..What's new here? heading I get these.. ( they all seem to point to the same code)

( ! ) Warning: substr() expects parameter 3 to be long, string given in C:\wamp2.1e\www\justwine\includes\modules\new_products.php on line 36
Call Stack
#	Time	Memory	Function	Location
1	0.0020	523056	{main}( )	..\index.php:0
2	0.2078	2598528	include( 'C:\wamp2.1e\www\justwine\includes\modules\new_products.php' )	..\index.php:354
3	0.2136	2609744	substr ( )	..\new_products.php:36

-------------------------

( ! ) Warning: substr() expects parameter 3 to be long, string given in C:\wamp2.1e\www\justwine\includes\modules\new_products.php on line 36
Call Stack
#	Time	Memory	Function	Location
1	0.0020	523056	{main}( )	..\index.php:0
2	0.2078	2598528	include( 'C:\wamp2.1e\www\justwine\includes\modules\new_products.php' )	..\index.php:354
3	0.2197	2613224	substr ( )	..\new_products.php:36

----------------------------

( ! ) Warning: substr() expects parameter 3 to be long, string given in C:\wamp2.1e\www\justwine\includes\modules\new_products.php on line 36
Call Stack
#	Time	Memory	Function	Location
1	0.0020	523056	{main}( )	..\index.php:0
2	0.2078	2598528	include( 'C:\wamp2.1e\www\justwine\includes\modules\new_products.php' )	..\index.php:354
3	0.2246	2615400	substr ( )	..\new_products.php:36

-------------------------------

( ! ) Warning: substr() expects parameter 3 to be long, string given in C:\wamp2.1e\www\justwine\includes\modules\new_products.php on line 36
Call Stack
#	Time	Memory	Function	Location
1	0.0020	523056	{main}( )	..\index.php:0
2	0.2078	2598528	include( 'C:\wamp2.1e\www\justwine\includes\modules\new_products.php' )	..\index.php:354
3	0.2291	2617576	substr ( )	..\new_products.php:36

---------------------------

( ! ) Warning: substr() expects parameter 3 to be long, string given in C:\wamp2.1e\www\justwine\includes\modules\new_products.php on line 36
Call Stack
#	Time	Memory	Function	Location
1	0.0020	523056	{main}( )	..\index.php:0
2	0.2078	2598528	include( 'C:\wamp2.1e\www\justwine\includes\modules\new_products.php' )	..\index.php:354
3	0.2342	2619920	substr ( )	..\new_products.php:36

-------------------------------

( ! ) Warning: substr() expects parameter 3 to be long, string given in C:\wamp2.1e\www\justwine\includes\modules\new_products.php on line 36
Call Stack
#	Time	Memory	Function	Location
1	0.0020	523056	{main}( )	..\index.php:0
2	0.2078	2598528	include( 'C:\wamp2.1e\www\justwine\includes\modules\new_products.php' )	..\index.php:354
3	0.2389	2622088	substr ( )	..\new_products.php:36

---------------------------------

Under the.. Reviews heading I get this..

( ! ) Warning: substr() expects parameter 3 to be long, string given in C:\wamp2.1e\www\justwine\includes\boxes\reviews.php on line 42
Call Stack
#	Time	Memory	Function	Location
1	0.0020	523056	{main}( )	..\index.php:0
2	0.2473	2603528	require( 'C:\wamp2.1e\www\justwine\includes\column_right.php' )	..\index.php:369
3	0.2615	2654552	require( 'C:\wamp2.1e\www\justwine\includes\boxes\reviews.php' )	..\column_right.php:19
4	0.2653	2656392	substr ( )	..\reviews.php:42

This is line 36 of new_products.php

 $p_desc = ''.substr(strip_tags($product['products_description']), 0, MAX_DESCR_1).' ...';

This is line 42 of boxes/reviews.php

 $review_prod = substr(strip_tags($rand_review_text),0,MAX_DESCR_REVIEWS).'...' ;

Thanks,

oz

Edited by ozstar, 20 April 2011, 06:13.

[goodnews]

ozstar, on 20 April 2011, 01:42, said:

HI,

I have just bought a template from them.

It says that it uses OsCommerce 2.2 RC2a.

I am about to update it to 2.3, hopefully it will not be a problem.

oz

Hi there,

Just a quicky, you say you have downloaded a templet from templetworld and have just started to use it...have you encountered any problums?

Thanks
John

[ozstar]

HI,

Yes I have it on my PC wamp and also on my Linux server although not public yet. I have added some mods to it and they all work.

I have tested the functions and as far as I can see everything does work, cart, email, orders etc in phpo 5.2.15. I still get some messages with php.5.3 but I think I will be okay once I get sometime with it.

It is still with all the sample products in it, but I will empty the db and poad my db fropm another store into it, once I am able.

So, this is the 2nd oscommerce shop I have bought from TM in about 6 months and both are fine.

Hope yours works out if you go ahead.

Good luck..


oz

Edited by ozstar, 22 April 2011, 11:09.

[goodnews]

ozstar, on 22 April 2011, 11:07, said:

HI,

Yes I have it on my PC wamp and also on my Linux server although not public yet. I have added some mods to it and they all work.

I have tested the functions and as far as I can see everything does work, cart, email, orders etc in phpo 5.2.15. I still get some messages with php.5.3 but I think I will be okay once I get sometime with it.

It is still with all the sample products in it, but I will empty the db and poad my db fropm another store into it, once I am able.

So, this is the 2nd oscommerce shop I have bought from TM in about 6 months and both are fine.

Hope yours works out if you go ahead.

Good luck..

Hi

Thanks a lot for you input, best of luck with your project.

John


oz

[ozstar]

Thanks

[germ]

ozstar, on 20 April 2011, 06:07, said:

This is line 36 of new_products.php

 $p_desc = ''.substr(strip_tags($product['products_description']), 0, MAX_DESCR_1).' ...';

This is line 42 of boxes/reviews.php

 $review_prod = substr(strip_tags($rand_review_text),0,MAX_DESCR_REVIEWS).'...' ;

Thanks,

oz

The errors mean the constants MAX_DESCR_1 and MAX_DESCR_REVIEWS aren't defined.

[ozstar]

Thank you for answering germ.

Sorry for the ignorance but how do I overcome that issue please?

Regards,

oz

[germ]

At the top of /includes/boxes/reviews.php change this code:

  Released under the GNU General Public License
*/
?>

To this:

  Released under the GNU General Public License
*/
define( MAX_DESCR_REVIEWS, '20');
?>

At the top of /includes/modules/new_products.php change this code:

  Released under the GNU General Public License
*/
?>

To this:

  Released under the GNU General Public License
*/
define( MAX_DESCR_1, '20');
?>

You may have to adjust the numbers (up or down) to suit your taste and/or your template requirements.

All it's doing is limiting the length of something shown on the page.

Templates do this quite often to avoid "breaking" the layout.