258 replies to this topic

[kymation]

This seems to be working correctly on my test site. Interesting. I'll try to do some more testing. Thnaks for the bug report.

Regards
Jim

[NodsDorf]

Okay, may since I have FWR Ultimate SEO URL's installed with .htacces mods maybe the difference.

[kymation]

URL rewriters do some very odd things. That's only one of the reasons I recommend they not be used.

It should be possible to rewrite the Canonical module to get rid of this problem. I'm in the middle of something else right now, but I'll take a look at this as soon as I'm done.

Regards
Jim

[kenkja]

Hi Jim

I've just installed v1.4.3 (Have now noticed v1.4.4 is available) without any obvious problems, so went to admin section and installed some of the category related modules, just to get a feel of what they do and again no problem.

I then installed module "Category Meta Keywords - Insert", which didn't work and uninstalling the module does not remove it from the editing/creating a category. It does not appear to stop the site from working as far as I know, so no great issue.

Could you confirm if this module is part of v1.4.3 as I'm unsure, I can see a file ht_category_keywords_insert.php in the download catalog/includes/modules/header_tags and in catalog/includes/languages/english/modules/header_tags folders but I don't know enough about php to understand how it might be affecting the admin

Regards

Ken

[kymation]

I have no idea how to solve a problem when all I'm given is "didn't work". Try to give a better description of the problem.

Most of the problems with these modules are caused by failing to upload one or more files to the correct locations. The two files you mentioned are essential to the module you are having problems with. Also, there are changes to admin/categories.php that are essential. Check that you have made those changes correctly.

Regards
Jim

[kenkja]

Sorry Jim I realise now my post did not adequately descriibe of the problem.

Firstly i should not have tried to upload this module as it is not in your very detailed of how to use your add-on

But I am a fool, and grasped onto the item which most seemed to suit my needs.

So

1. I have no idea if the existance of "Category Meta Keywords - Insert" within the admin->modules section is a result of your add-on, for all I know it may well have been there before I uploaded the add-on

2. In relation to "it did not work"

after installing this module, on a category create/edit page, i find an additional box, which at present appears underneath the categories_meta_desrciption box.

Above it, appears

[color=rgb(0,0,0)]"MODULE_HEADER_TAGS_EDIT_CATEGORIES_KEYWORDS"[/color]

[color=rgb(0,0,0)]If I enter any details in this box, the source code for the page , changes to include an extra line of meta category keyword, but there are no keywords specified.[/color]

[color=rgb(0,0,0)]If I return to the admin and try to edit a category for which I have previously added info into this box, the previously input info has been deleted.[/color]

Is this making any sense, Jim

[kenkja]

Jim

Please ignore the rgb statements.

ken

[kymation]

You've found a bug, although there may be more to your problem than that. Find this code in admin/includes/languages/english.php:

// Start Modular SEO header Tags
  define( 'MODULE_HEADER_TAGS_PRODUCT_TITLE_INSERT_TITLE', 'Products Head Title:' );
  define( 'MODULE_HEADER_TAGS_PRODUCT_DESCRIPTION_INSERT_TITLE', 'Products Meta Description:' );
  define( 'MODULE_HEADER_TAGS_EDIT_CATEGORIES_TITLE', 'Category Head Title:' );
  define( 'MODULE_HEADER_TAGS_EDIT_CATEGORIES_DESCRIPTION', 'Category Meta Description:' );

and add after it:

  define( 'MODULE_HEADER_TAGS_EDIT_CATEGORIES_KEYWORDS', 'Category Meta Keywords:' );
  define( 'MODULE_HEADER_TAGS_PRODUCT_KEYWORDS_INSERT_TITLE', 'Products Meta Keywords:' );

Let me know if that helps. I suspect another problem will show up after this one is fixed. And thanks for the bug report; I'll fix that one with the next release.

Regards
Jim

[kenkja]

Hi Jim,

I've added the define statements and "MODULE_HEADER_TAGS_EDIT_CATEGORIES_KEYWORDS" has now been replaced by "Category Meta Keywords:" as you would expect.

As I had previously removed the module, the Categories Meta Keywords box I guess should not have been shown when editing/creating a new category but it was still there, which may be the part of the additional problem you suspected may happen.

I then re-installed the module, the box and title are now still present when editing/creating categories, just as you would expect it to be.

After entering "motorcycle," and saving the edit, I viewed the page on the site and it appears to be working normally, viewing the source code for that page, an extra line has appeared

<meta name="keywords" content="" />

So the code is clearly trying to do its job, but has not managed to save the keyword which suggests some issue with the database. So via phpmyadmin I checked the database the table categories_description has now three extra fields "head_title" "head_description" and "head_keywords", they are all varchar(255) with utf8_unicode_ci collation.

For the one category I have so far altered the head_title & head_description contain the data expected however head_keywords is blank, so saving the category edit/create is not writing to that field, I added "motorcycle trials" to the field via phpmyadmin and reviewed the source code.

<meta name="keywords" content="motorcycle trials" />

being the expected result, so that pretty much seems to confirm that the issue is in relation to writing these keywords to the database.

Finally I undid my manual alteration to the database, removed the module via admin, rechecked source code, database and edited the category via the admin. As expected the module has been removed from Header Tags list of installed modules and the <meta name="keywords" line removed from the source code. The database still included the head_keywords field and the Keywords box still appears on the edit/create category page.

So we have 2 problems

1. When the module is installed its not writing to the database

2. When the module is removed its not deleting the box from the category edit page.

To be fair I can live with these issues as they don't appear to hinder the workings of the rest of the site and I do all of my database editing via phpmyadmin by uploading csv files.

Just a reminder my header tags install is v1.4.3, hope this helps.

regards

ken

[kymation]

The keywords tag is a worthless waste of time anyway, so I wouldn't worry about it. Just remove the module and leave it out. I'll fix the bugs as soon as I have some time. Thanks for the detailed bug report; that helps a lot.

Regards
Jim

[kenkja]

Thanks Jim,

Will do so, will it be safe for me to update to v1.4.4

cheers

ken

[kymation]

1.4.4 fixes a bug in the Canonical module. Update if you need that module; otherwise don't bother.

Regards
Jim

[asgo]

I too have a problem with keywords. It is the Product Meta keyword - Insert.
It shows up as 2 edit windows in the products page but produces an empty tag on the HTML page (<meta name="keywords" content="" />).
Any ideas?

Anders

[njbeacher]

If I use the Product title - Category Name, it only picks up the category name that is one level up. If that category is a subcategory and there is a higher level category, how would you include that one as well in the Title?

Thanks.

[kymation]

That would require custom coding. You need to detect whether the current category has a parent of 0 (top level) and if not, retrieve the parent's name and add it to the display string.

Regards
Jim

[AndrewBevan]

Hi,
I have just started using this addon... And for some reason my Meta Keywords are not being stored in the DB after adding them to a new product or category...
Any help is appreciated.

Thanks
Andrew

[kymation]

Meta Keywords appears to have a bug. I'll take a look at it as soon as I have a chance. Since Meta Keywords are completely useless, please use your time doing something useful.

Regards
Jim

[cw30jp]

Hi Kymation,
Fantastic addon! I recently upgraded to 2.3.1 and then disappeared from the Search Engines, and I think it is because I didn't have this addon.

Regarding the Meta Keywords problem, I found the required code to insert the keywords into the database was missing from;
/admin/includes/modules/header_tags/categories_products_process.php

eg.
// Check whether the products_description table has been altered
$check_structure_query_raw = "describe " . TABLE_PRODUCTS_DESCRIPTION;
$check_structure_query = tep_db_query($check_structure_query_raw);

$products_field_exists = false;
while ($check_structure_data = tep_db_fetch_array($check_structure_query)) {
if ($check_structure_data['Field'] == 'head_title') {
$products_field_exists = true;
}

if ($check_structure_data['Field'] == 'head_description') {
$products_field_exists = true;
}
------------------------- this part was missing throughout--------------------------
if ($check_structure_data['Field'] == 'head_keywords') {
$products_field_exists = true;
}
---------------------------------------------------------------------------------------------
}

I have added the required code and it is working fine for me. The modified categories_products_process.php file is attached.
 categories_products_process.php   6.68K   5 downloads

Thanks again

[kymation]

Thanks for the bug report, and double thanks for the code. I'll fix that in the next release.

Just don't expect the keywords to help you with the search engines. It won't.

Regards
Jim

[kymation]

I've uploaded a new version to the Addons repository. This release fixes a bug affecting the Products and Categories Keywords tags. Note that Keyword tags are still worthless as far as search engines go; they're only good for storing a list of keywords that you might want to use elsewhere. There are update instructions in the included User's Manual if you need them.

This is all you need to install, however the Extras have been removed to make the package fit in the repository.

Regards
Jim