373 replies to this topic

[foxp2]

npn2531, on 14 October 2010 - 05:24 PM, said:

Just a quick note, check specials.php, it looks like a typo or something is causing the left column to drop off, thus the rest of the page is not stacking up correctly.

yes, just a simple modification :
replace (Line 77-82) :

<?php
  }

  require(DIR_WS_INCLUDES . 'template_bottom.php');
  require(DIR_WS_INCLUDES . 'application_bottom.php');
?>

with

<?php
  }
?>
  </div>
</div>
<?php
  require(DIR_WS_INCLUDES . 'template_bottom.php');
  require(DIR_WS_INCLUDES . 'application_bottom.php');
?>

[npn2531]

I see that includes/classes/box.php is in 2.3 but I can't find any references to the functions in the catalog files. For example, 'new infoBox($info_box_contents)' , is not  (or appears to not be) used in building the infoboxes. Personally I'm thrilled the infoboxes seem to be cut loose from the box class, but why is the box class file included in 2.3?

[spoofy]

Harald Ponce de Leon, on 14 October 2010 - 12:40 PM, said:

Hi All..

The Online Demonstration site has been updated with the latest changes for v2.3:

http://demo.oscommerce.com

The frontend now has a jQuery UI compatible CSS layout and is based on the 960 Grid System CSS framework.

A jQuery UI compatible CSS layout allows the colour scheme to be easily updated using jQuery's ThemeRoller tool:

http://jqueryui.com/themeroller/#themeGallery

By default, the Redmond theme package is included in the v2.3 download package. Similarly, the image buttons have been replaced using jQuery UI Button widgets that not only look and function great, but help with language definitions where creating separate images for each button is no longer necessary.

The CSS layout is based on the 960 Grid System CSS framework:

http://960.gs

This is a very flexible and browser compatible 960px wide layout perfect for organizing blocks of content in a defined column layout. The main content of the page is defined higher in the HTML source for SEO improvements and the layout is compatible to RTL languages.

Although not all shops would like a 960px wide layout, it is easy to implement a custom layout utilizing the new template_top.php and template_bottom.php files.

Feedback on these changes would be appreciated; please keep in mind that we are still fine-tuning the CSS definitions for the updated layout.

Thanks,

Hey,

I have spent the last few hours playing with the latest release and so far it's impressive!

Since I only played around for short period of time, I didn't come across any bugs / issues.

[scandic_outlet]

in the demostore
http://demo.oscommerce.com/index.php?cPath=3

in IE 8 - there are some strange visual things happening when browsing the sites. Info boxes misplaced etc.

regards
Mike
____________
Hip hop og streetwear online http://www.shakk.dk

[Biancoblu]

scandic_outlet, on 15 October 2010 - 01:45 PM, said:

in IE 8 - there are some strange visual things happening when browsing the sites. Info boxes misplaced etc.

regards
Mike

you are right, in IE8 it's all to the left and both the left and right columns appear on the left handside.

[npn2531]

Here is one fun thing you can do with 2.3 since the Jquery files are already in the header. Paste this anywhere on a catalog page and you have instant tabs that match the themeroller theme of the shop:
This is copied directly off the JQuery site with no modifications. (Ideally you'd put the script elsewhere, but this works for demonstration)

<script>
  $(document).ready(function() {
	$("#tabs").tabs();
  });
  </script>
  <div id="tabs">
	<ul>
		<li><a href="#fragment-1"><span>One</span></a></li>
		<li><a href="#fragment-2"><span>Two</span></a></li>
		<li><a href="#fragment-3"><span>Three</span></a></li>
	</ul>
	<div id="fragment-1">
		<p>First tab is active by default:</p>
		<pre><code>$('#example').tabs();</code></pre>
	</div>
	<div id="fragment-2">
		Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.
		Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.
	</div>
	<div id="fragment-3">
		Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.
		Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.
		Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat.
	</div>
</div>

[Hotclutch]

<BR> and <BR /> are being used, at least on index.php. Should just be one or the other, else your HTML validation is out.

[npn2531]

I think how  template_top.php  is set up is going to constrict how flexible you can be with adding stylesheet and javascript references. Their is a discussion upstream this. All the head data (<head></head>, as well as the content header (header.php) is in template_top.php. This means every stylesheet and javascript reference placed within the <head> tags, which is where they should be (yes?), is going to load for every single page. For example if you have JQuery Tabs and Pretty Photo on product_info.php, ideally you would place the 4 or 5 unique stylesheets, javascript references, and javascript snippets, above the </head> on product_info.php and only on product_info.php, which would be the only place the shop would use them. You can do this with 2.2

The only way you can get something like this only on product_info.php  in 2.3 is to place those references below the header, in essence, in the middle of the content. Which I have tried in 2.3,  besides being ridiculous, it doesn't work. Of course I have a lot to learn about JQuery.

Another example of  a Javascript heavy application that only needs to load only on a limited number of pages is 'One Page Checkout'.  You don't need all that stuff in the product display or information pages, slowing stuff down. But with 2.3 what do you do? . You can't even just cut the </head> tag off the template_top and paste in the catalog pages, (the header.php is in the way), without redesigning the whole layout.

[spoofy]

npn2531, on 15 October 2010 - 11:28 PM, said:

I think how  template_top.php  is set up is going to constrict how flexible you can be with adding stylesheet and javascript references. Their is a discussion upstream this. All the head data (<head></head>, as well as the content header (header.php) is in template_top.php. This means every stylesheet and javascript reference placed within the <head> tags, which is where they should be (yes?), is going to load for every single page. For example if you have JQuery Tabs and Pretty Photo on product_info.php, ideally you would place the 4 or 5 unique stylesheets, javascript references, and javascript snippets, above the </head> on product_info.php and only on product_info.php, which would be the only place the shop would use them. You can do this with 2.2

The only way you can get something like this only on product_info.php  in 2.3 is to place those references below the header, in essence, in the middle of the content. Which I have tried in 2.3,  besides being ridiculous, it doesn't work. Of course I have a lot to learn about JQuery.

Another example of  a Javascript heavy application that only needs to load only on a limited number of pages is 'One Page Checkout'.  You don't need all that stuff in the product display or information pages, slowing stuff down. But with 2.3 what do you do? . You can't even just cut the </head> tag off the template_top and paste in the catalog pages, (the header.php is in the way), without redesigning the whole layout.

There are 2 ways you can do this..

1) as mentioned previously somewhere in this thread, you can check and see if the file is product_info and load extra files in the <head>
or
2) in template_top.php just echo $optionalHeadTags and define the $optionalHeadTags in the product_info file

[npn2531]

I don't understand how that would work. There are no <head> tags in the catalog pages. If you echoed, say #optionalHeadTags in product_info.php, anywhere you placed the variable it would be outside the <head> tags, and in fact below header.php well within the content.

[spoofy]

Well, you don't echo it into product_info. You echo it in template_top within the <head> tag.

Here is how it would work

let's say conditions.php has

$optionalHeadTags = '';

while products_info.php has

$optionalHeadTags = '<script>blah blah blah</script>';

so in template_top.php you will always do (meaning regardless of which page the script is calling)

echo $optionalHeadTags;

this would be placed within the <head> tag obviously.

I hope that makes sense

[spoofy]

scandic_outlet, on 15 October 2010 - 01:45 PM, said:

in the demostore
http://demo.oscommerce.com/index.php?cPath=3

in IE 8 - there are some strange visual things happening when browsing the sites. Info boxes misplaced etc.

regards
Mike
____________
Hip hop og streetwear online http://www.shakk.dk

That was a very easy fix for me. I changed the doctype and viola! it worked!

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

[Hotclutch]

spoofy, on 16 October 2010 - 12:48 AM, said:

That was a very easy fix for me. I changed the doctype and viola! it worked!

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

In which file is this please? Template top has the doctype as

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

[npn2531]

spoofy, on 16 October 2010 - 12:26 AM, said:

Well, you don't echo it into product_info. You echo it in template_top within the <head> tag.

Here is how it would work

let's say conditions.php has

$optionalHeadTags = '';

while products_info.php has

$optionalHeadTags = '<script>blah blah blah</script>';

so in template_top.php you will always do (meaning regardless of which page the script is calling)

echo $optionalHeadTags;

this would be placed within the <head> tag obviously.

I hope that makes sense

Yes it does. You mean declare the variable in conditions.php ( or product_info.php or whatever) , above the reference to template_top.php  like say,

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

  $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_PRODUCT_INFO));
$optionalHeadTags = '<script>blah blah blah</script>';
  require(DIR_WS_INCLUDES . 'template_top.php');

Then echo $optionalHeadTags in template_top.php:

<link rel="stylesheet" type="text/css" href="stylesheet.css">
<?php echo $optionalHeadTags; ?>
<?php echo $oscTemplate->getHeaderTags(); ?>

Edited by npn2531, 16 October 2010 - 01:48 AM.

[spoofy]

npn2531, on 16 October 2010 - 01:44 AM, said:

Yes it does. You mean declare the variable in conditions.php ( or product_info.php or whatever) , above the reference to template_top.php  like say,

require(DIR_WS_LANGUAGES . $language . '/' . FILENAME_PRODUCT_INFO);

  $breadcrumb->add(NAVBAR_TITLE, tep_href_link(FILENAME_PRODUCT_INFO));
$optionalHeadTags = '<script>blah blah blah</script>';
  require(DIR_WS_INCLUDES . 'template_top.php');

Then echo $optionalHeadTags in template_top.php:

<link rel="stylesheet" type="text/css" href="stylesheet.css">
<?php echo $optionalHeadTags; ?>
<?php echo $oscTemplate->getHeaderTags(); ?>

That's exactly correct.

[spoofy]

Hotclutch, on 16 October 2010 - 01:07 AM, said:

In which file is this please? Template top has the doctype as

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

That's right. You have to change that in template_top.php

So replace the doctype I posted above with the one you see in template_top and it should work

[Hotclutch]

spoofy, on 16 October 2010 - 02:07 AM, said:

That's right. You have to change that in template_top.php

So replace the doctype I posted above with the one you see in template_top and it should work

Thanks for that, works perfectly. V2.2 was HTML not XHTML.

[GemRock]

Harald Ponce de Leon, on 14 September 2010 - 08:03 PM, said:

...
Please take this opportunity and download the current state of v2.3 from our Github repository:

http://github.com/os...rce/oscommerce2

I will be happy to send you a ZIP file if you do not have git installed to download the source files.
...

hi Harald,
I wonder if you still make the zip file offer? if so I would like to have a copy to test it out. I have no idea I have to install git (and where to get it) as I dont/wont use git. your link above (and that from birt's thread - 2.3 question time - he doesnt even mention installation of git) only offers the 3 old 2.2rcxx versions when clicking on the download button on the right.
thank you,

Ken

[burt]

Hi Ken

If you hit the download link button, and use the "download source" bit (zip), you will download the latest (but it will be named something like osCommerce-oscommerce2-v2.2rc2a-257-g9af1c5e

You do not need git installed.  However, it is easy to install and use.

[GemRock]

burt, on 16 October 2010 - 12:59 PM, said:

Hi Ken

If you hit the download link button, and use the "download source" bit (zip), you will download the latest (but it will be named something like osCommerce-oscommerce2-v2.2rc2a-257-g9af1c5e

You do not need git installed. However, it is easy to install and use.

thanks burt. i could have been a bit more adventurous and not hindered by the file name. 2 things noticed so far: on the positive side, v2.3 offers change of admin folder during installation, which would save the agony of some having difficulties of doing so for the old versions. the negative imo is that it should have change the document type from html4.01 to xhtml 1.0. luckly, there is only one file file and one line that needs to change.

do not think itd have lots of bugs in it.

Ken