154 replies to this topic

[blonde_one]

Hi Jim,   I have installed the Banner Rotator and it functions perfectly and looks beautiful on the site, thanks so much for this great contribution! I did notice however that it isn't outputting any alt text. The language id is set to 1 and there is text entered in both the banners_title and banners_html_text but neither is being output for any of the banners. Thanks in advance for your help, it is greatly appreciated!


Best Regards,

~ Mandy

[kymation]

The text in banners_html_text should show up. The banner rotator uses the stock osCommerce image function for this, so if the banner images show up the text should show as well. Perhaps the Javascript rotator is interfering. I don't know what's wrong so I can't suggest a fix.

Regards
Jim

[blonde_one]

Hi Jim, Thanks for the quick repy! In banner_rotator.php I changed the following:

echo tep_image(DIR_WS_IMAGES . $banner['banners_image']);

to this:

echo tep_image(DIR_WS_IMAGES . $banner['banners_image'], $banner['banners_html_text']);

And now it outputs the alt and the title tags Is this the correct way of doing it?
Thanks again!

Best Regards,

~ Mandy

[kymation]

You changed the code to the way it is in Version 1.2. Where did you get one without that code? And yes, that's the way it should be.

Regards
Jim

[blonde_one]

Oh, great I thought I was using the latest version, I downloaded 1.2.1 from the contributions
http://addons.oscommerce.com/info/7461

...which I now see was not posted by you, not good, I think I will download v.1.2 that you posted and compare all my code just to be sure that isn't my only issue! Thanks so much!

Best Regards,

~ Mandy

[khoking]

Managed to install this contribution successfully! Thank you very much for the wonderful and simple to use contribrition! I have been looking for one for SOoooo long!

One problem. On my computer / PC and Mac, no problem for the banner to display properly.

http://shashinki.com/shop/

However, when browse using ipad, the banners are not stacked up, but displayed all out vertically. Has anyone tested on iPad?

(Tried on Android phone, no problem.)

[kymation]

That sounds like the Javascript is not working. Many mobile browsers have a problem with this.

Regards
Jim

[khoking]

kymation, on 21 August 2012 - 11:53 PM, said:

That sounds like the Javascript is not working. Many mobile browsers have a problem with this.

Regards
Jim

Hi Jim,

No problem on Android phone, but on iPad no good.

Any solution to that?

[kymation]

Maybe upgrade the jQuery file to the latest version? osCommerce 2.2x is no longer supported, so I doubt this will ever be fixed. Upgrade to 2.3.3 and it should work.

Regards
Jim

[khoking]

kymation, on 22 August 2012 - 04:40 PM, said:

Maybe upgrade the jQuery file to the latest version? osCommerce 2.2x is no longer supported, so I doubt this will ever be fixed. Upgrade to 2.3.3 and it should work.

Regards
Jim

Hi Jim,

I just noticed the same problem using IE.

Fine on FireFox, but IE no good.

I have upgraded my jquery to the latest 1.8.0 version, still same problem.

http://shashinki.com/shop/

[khoking]

Can someone help? I can pay USD10 via PayPal for the solution. The solution can be posted for all to use.

[khoking]

I have found the problem in the CSS part.

#bannerRotator ul {
  list-style: none;
  padding: 0;
  position: relative;
}

Change to:

#bannerRotator ul {
  list-style-type: none;
  padding: 0;
  position: relative;
}

[kymation]

That's the kind of thing I would expect from Internet Explorer's poor CSS implementation, not from a modern browser. Good catch. Thanks for posting the fix.

Regards
Jim

[zediks]

Hi,

My website is www.thevine.be
Banner rotator is working perfect. But only in Firefox and Chrome. It bugs in IE. Does anyone have an idea?


edit//  OK, I didn't read las post. sorry. I'll try the css fix

edit// no the css doesn't fix it. In IE the banner doesn't center itself

Edited by zediks, 04 November 2012 - 12:07 PM.

[kymation]

The banner rotator does not center the banners. You need to make your banners the correct size to fit the rotator.

Regards
Jim