41 replies to this topic

[santaya]

Anybody solve this? I'm having the same problem with the empty string.

robweidman, on 10 May 2010, 22:31, said:

I'm having the exact same problem as lyonsperf (Matt). There are no PHP errors per se. Things seem to go downhill from this point in products_ship_estimator.php:

Line 30: $products_id = (int) $_GET['pid'];

The result is the empty string. If I can be of further assistance, let me know.

[NDboots]

kymation, on 24 April 2010, 02:01, said:

Yes, I did need that with the error checking. It shows what I thought it would -- the ZIP code and country are not getting sent. It's also no help. Oh well.

I'm pretty much out of ideas at this point. This code works on every machine I have access to right now, and it works for many other people as well. There is something in your setup that is breaking it, and I have no way to find out what that is. You'll need to do some debugging yourself.

One further hint: The Close button is not an option -- it's always shown. If you're not seeing it, the page is likely halting on an error before it gets to that point. The failure to pass the customer's input values may also be due to a hidden error. Turn on all errors in osCommerce or look at your error log. Error messages would be very helpful at this point.

Regards
Jim

The Close button does not show in mine either. The problem is here in /catalog/ship_estimator.php

About line 888 it reads:
<?php echo '<a href="' . tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=end', 'NONSSL') . '">' . tep_image_button('button_close_window.jpg', IMAGE_BUTTON_CLOSE) . '</a>'; ?>

The problem is the "button_close_window.gif" is the file we uploaded, it is not a .jpg format file. So, just change .jpg to .gif and your "Close" button will show.

I'm having same problem as Matt in the shopping cart "What's In My Cart?" section, pre-login /catalog/shopping_cart.php?osCsid=a5ec130564b183c1d42dff893fafd73a This is very confussing for my customers!

Ship Estimator 2.2.2 will not calculate shipping if shipping was not calculated prior to pressing the "Buy Now" button in the individual items listing. In the "What's In My Cart?" section, I get no error, same window reloads waiting for zipcode and country. But the URL does have the word "error" in it: /catalog/ship_estimator.php?action=ship_error&osCsid=a5ec130564b183c1d42dff893fafd73a

[NDboots]

Well, I was experiencing the same thing as Matt when I installed Ship Estimator 2.2.2. Could'nt seem to find an answer, so just studied over things a bit. I'm not a Professional by no means, so back up your original files before you try this. But, this seems to work for me as guest not logged in and with test logins. I found the product section estimator would work okay from /catalog/products_ship_estimator.php so I copied the following from it, which start at about line 45.

switch ($action) {
case 'process':
//Error if customer is not logged in and address is not set
if (!tep_session_is_registered ('customer_id') && (!tep_session_is_registered ('shippostcode') || !tep_session_is_registered ('shipcountry') || (!tep_session_is_registered ('shipzone') && SHIP_ESTIMATOR_USE_ZONES == 'true') ) ) {
$error_code = '';
if (!tep_not_null ($_POST['shippostcode']) || !tep_not_null ($_POST['shipcountry']) ) {
if (!tep_not_null ($_POST['shippostcode']) ) $error_code .= '&error_shippostcode=1';
if (!tep_not_null ($_POST['shipzone']) && SHIP_ESTIMATOR_USE_ZONES == 'true') $error_code .= '&error_shipzone=1';
if (!tep_not_null ($_POST['shipcountry']) ) $error_code .= '&error_shipcountry=1';
tep_redirect (tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=ship_error' . $error_code, 'NONSSL'));
exit; // Don't do anything else
} //if (!tep_not_null
} //if (!tep_session_is_registered


*******Next I opened /catalog/ship_estimator.php (the file with the problem) and hunted for the following which was very similar but not quit the same. It starts around line 41. Next, I deleted the below and replaced it with the above in /catalog/ship_estimator.php and now I don't seem to have Matt's problem. PLEASE NOTE: I already did change the words above - FILENAME_PRODUCTS_SHIP_ESTIMATOR to FILENAME_SHIP_ESTIMATOR - to go with the /catalog/ship_estimator.php file it is going into.

switch ($action) {
case 'process':
if (!tep_session_is_registered ('customer_id') && (!tep_session_is_registered ('shippostcode') || !tep_session_is_registered ('shipcountry') || (!tep_session_is_registered ('shipzone') && SHIP_ESTIMATOR_USE_ZONES == 'true') ) ) {
$error_code = '';
if (!tep_not_null ($_POST['shippostcode']) ) $error_code .= '&error_shippostcode=1';
if (!tep_not_null ($_POST['shipzone']) && SHIP_ESTIMATOR_USE_ZONES == 'true') $error_code .= '&error_shipzone=1';
if (!tep_not_null ($_POST['shipcountry']) ) $error_code .= '&error_shipcountry=1';
tep_redirect (tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=ship_error' . $error_code, 'NONSSL'));
exit; // Don't do anything else
} //if (!tep_session_is_registered

Edited by NDboots, 09 January 2011, 05:13.

[ken0306]

has anyone get it works with UPS XML service yet? I have to install the 2.2.2 version to work with canada post, but it doesn't works with ups xml, it only calculate with weight, not dimension.
ken

[robweidman]

I just installed 2.2.3 today and ran into similar errors that others were having. The code below from ship_estimator.php starts around line 42:

    case 'process':
      if (!tep_session_is_registered ('customer_id') && (!tep_session_is_registered ('shippostcode') || !tep_session_is_registered ('shipcountry') || (!tep_session_is_registered ('shipzone') && SHIP_ESTIMATOR_USE_ZONES == 'true') ) ) {
        $error_code = '';
          if (!tep_not_null ($_POST['shippostcode']) ) $error_code .= '&error_shippostcode=1';
          if (!tep_not_null ($_POST['shipzone']) && SHIP_ESTIMATOR_USE_ZONES == 'true') $error_code .= '&error_shipzone=1';
          if (!tep_not_null ($_POST['shipcountry']) ) $error_code .= '&error_shipcountry=1';

          tep_redirect (tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=ship_error' . $error_code, 'NONSSL'));
          exit; // Don't do anything else

      } //if (!tep_session_is_registered

I'm not a PHP developer by any means. So take this with a grain of salt. It seems to me in this section of code, that if customer_id isn't valid, along with some combination of shippostcode, shipcountry and shipzone (but only if ship_estimator_use_zones is true), then it attempts to set the values for shippostcode, shipzone and shipcountry with the $_POST.

That $_POST may well have been successful, but no matter because the next line of code redirects with an error. Therefore, in order to get mine working (your mileage may vary), I added a check before redirecting. So, if the $error_code doesn't get set to something, there is actually no error and processing can proceed.

    case 'process':
      if (!tep_session_is_registered ('customer_id') && (!tep_session_is_registered ('shippostcode') || !tep_session_is_registered ('shipcountry') || (!tep_session_is_registered ('shipzone') && SHIP_ESTIMATOR_USE_ZONES == 'true') ) ) {
        $error_code = '';
          if (!tep_not_null ($_POST['shippostcode']) ) $error_code .= '&error_shippostcode=1';
          if (!tep_not_null ($_POST['shipzone']) && SHIP_ESTIMATOR_USE_ZONES == 'true') $error_code .= '&error_shipzone=1';
          if (!tep_not_null ($_POST['shipcountry']) ) $error_code .= '&error_shipcountry=1';

          if ($error_code != '') {
              tep_redirect (tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=ship_error' . $error_code, 'NONSSL'));
              exit; // Don't do anything else
          }
      } //if (!tep_session_is_registered

Again, I'm not a PHP developer. Maybe there's a deeper issue and my solution just masked it.

FWIW, the original solution, as well as this one works fine with USPS XML.

[kymation]

Sorry, but your change just masks an error. This code is an error handler. Anything that gets past this line (evaluates to true) is an error:

      if (!tep_session_is_registered ('customer_id') && (!tep_session_is_registered ('shippostcode') || !tep_session_is_registered ('shipcountry') || (!tep_session_is_registered ('shipzone') && SHIP_ESTIMATOR_USE_ZONES == 'true') ) ) {

The real problem is that one of the error conditions is not detected. The Zone needs to be checked for content if it is enabled. Add this line after the above::

          if (!tep_not_null ($_POST['shipzone']) && SHIP_ESTIMATOR_USE_ZONES == 'true' ) $error_code .= '&error_shipzone=1';

That error code then needs to be detected and an error message set in the estimator box. Try this (without your additions) and see if it now works as expected.

Regards
Jim

[Gyakutsuki]

MVS Shipping Cost Estimator work with 2.3 ?

[kymation]

Yes. You may want to change the buttons to match your 2.3.1 store, but it works anyway.

Regards
Jim

[varina]

Jim,

I am trying to convert your Shipping Cost Estimator to work with my 2.3.1. store. I am having trouble converting the code to make the pop up window work with my store buttons.
I don't know how to put in the reference to the javascript function. Right now when I click the ship estimate button it just loads the information into the same window.

I trying to modify this:

<!-- added for pop-up ship estimator //-->
  <div class="buttonSet">
    <span class="buttonAction"><?php echo '<a href="javascript:estimatorpopupWindow' .tep_draw_button(IMAGE_BUTTON_SHIP_ESTIMATOR, 'triangle-1-e', tep_href_link(FILENAME_SHIP_ESTIMATOR, '', 'SSL')); ?></span>
  </div>
<!-- added for pop-up ship estimator end //-->

Right now I have this:

<!-- added for pop-up ship estimator //-->
  <div class="buttonSet">
    <span class="buttonAction"><?php echo '<a href="javascript:estimatorpopupWindow' .tep_draw_button(IMAGE_BUTTON_SHIP_ESTIMATOR, 'triangle-1-e', tep_href_link(FILENAME_SHIP_ESTIMATOR, '', 'SSL')); ?></span>
  </div>
<!-- added for pop-up ship estimator end //-->

Which does not work. Could you please help me straighten this out?

Thanks,

Varina

[kymation]

I don't see any difference between those two code snippits. In any case, use the following code where you want the button to appear on shopping_cart.php:

// MVS Shipping Estimator start
    if (SHIP_ESTIMATOR_BUTTON_SHOPPING_CART == 'true') {
	  echo tep_draw_button (IMAGE_BUTTON_SHIP_ESTIMATOR, 'check', 'javascript:estimatorpopupWindow(\'' . tep_href_link (FILENAME_SHIP_ESTIMATOR, '', 'SSL') . '\')');
    }
// MVS Shipping Estimator end

You also need the Javascript function it calls. Put this near the top of shopping_cart.php:

  // Insert the javascript for the shipping estimator popup
  $head_javascript .= '  <script language="javascript" type="text/javascript">' . "\n";
  $head_javascript .= "    function estimatorpopupWindow(URL) {window.open(URL,'shippingestimator','toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=1,width=800,height=600')}\n";
  $head_javascript .= '  </script>' . "\n";
  $oscTemplate->addBlock( $head_javascript, 'header_tags' );

That should bring up the popup for you.

Regards
Jim

[varina]

Jim,

Thanks for the reply. I posted the wrong snippet of code yesterday. Wrong copy / paste function on my part. I should have proofread it better. Sorry about that.

At the top of my shopping_cart.php file I have this code:

<!-- added for pop-up ship estimator //-->
<SCRIPT LANGUAGE="JavaScript"><!--
  function estimatorpopupWindow(URL) {window.open(URL,'shippingestimator','toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=1,width=800,height=600')}
//--></script>
<!-- added for pop-up ship estimator end //-->

Then I used this code just above the checkout button:

<!-- added for pop-up ship estimator //-->
<td align="left" class="main">
<?php echo '<a href="javascript:estimatorpopupWindow(\'' .  tep_href_link(FILENAME_SHIP_ESTIMATOR, '', 'SSL') . '\')">' . tep_image_button('button_estimate_shipping.gif', IMAGE_BUTTON_SHIP_ESTIMATOR) . '</a>'; ?>
</td>
<!-- added for pop-up ship estimator end //-->

It works just fine. I just wanted to change button from an image to the button set my store uses using the <div> classes.

I tried your new code, but it isn't working with my page, the code shows up in the shopping cart, not a button.

I changed it to this:

	   <?php echo tep_draw_button (IMAGE_BUTTON_SHIP_ESTIMATOR, 'check', 'javascript:estimatorpopupWindow(\'' . tep_href_link (FILENAME_SHIP_ESTIMATOR, '', 'SSL') . '\')');
   ?>

Now it seems to work. Now I just have to figure out how position it right and restyle the pop up window. Thanks for helping!

-Varina

[varina]

I spoke too soon. Everything works great in Chrome, Firefox, but in IE I am missing my infoboxes and the checkout button. I noticed I have this error:


Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.0.3705; .NET CLR 1.1.4322; Media Center PC 4.0)
Timestamp: Sat, 18 Feb 2012 18:24:58 UTC


Message: HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)
Line: 0
Char: 0
Code: 0
URI: http://pinecreekwood.com/catalog/shopping_cart.php

Any ideas on how I fix this? If I remove the javascript code my page works again.

Varina

[kymation]

This is due to invalid HTML. Your shopping cart page has this:

<span class="tdbLink"><a id="tdb6" href="javascript:estimatorpopupWindow('https://pinecreekwood.com/catalog/ship_estimator.php')"><b>Get Shipping Quote</a></span>

Note that the bold tag is not closed. You should not be using bold here anyway: The tag is deprecated in XHTML, and bold text in the buttons should always be handled by the theme.

I didn't check all of your HTML, so there could be other errors as well. I suggest tunning the W3C Validator on your pages to find the errors.

Regards
Jim

[varina]

Sigh. Thanks Jim. That fixed my issue for the shopping_cart file.

I finally got used to the code from 2.2 This 2.3.1 code is a bit harder for me to figure out. Hopefully it will start making more sense soon.

Now I have to go back and undo the button changes I made on the ship_estimator file...since it is throwing errors in IE too.

Grumble, grumble...

[varina]

Jim,

Sorry to keep bugging you, but I am getting frustrated on the button changes is the ship_estimator file. I found your thread on how to convert the 2.2 buttons to 2.3.1. and I thought I could figure it out, but every time I try to change the buttons in this file I lose the functionality, and get standard windows buttons instead of my theme buttons. I am not sure what I am doing wrong.

The three I would like to change are:

Close:

<!-- close_window //-->
  <tr>
    <td><?php echo tep_draw_separator('pixel_trans.gif', '100%', '10'); ?></td>
  </tr>
  <tr>
    <td>
	  <p class="smallText" align="center">
	  <?php echo '<a href="' . tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=end', 'NONSSL') . '">' . tep_image_button('button_close_window.gif', IMAGE_BUTTON_CLOSE) . '</a>'; ?>
	  </p>
    </td>
  </tr>
<!-- close_window_eof //-->

Reset (New Address):

<!-- reset //-->
  <tr>
    <td><table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">
	  <tr class="infoBoxContents">
	    <td><table border="0" width="100%" cellspacing="0" cellpadding="2">
	  <tr>
	    <td class="main" width="100%" align="center"><?php echo TEXT_RESET_EXPLAIN; ?> </td>
	  </tr>
	  <tr>
	    <td><?php echo tep_draw_separator ('pixel_trans.gif', '100%', '10'); ?></td>
	  </tr>
	  <tr>
	    <td class="main" width="100%" align="center"><?php echo '<a href="' . tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=reset', 'SSL') . '">' . tep_image_button('button_reset.gif', IMAGE_BUTTON_RESET_FORM) . '</a>'; ?> </td>
	  </tr>
	    </table></td>
	  </tr>
    </table></td>
  </tr>
<!-- reset_eof //-->

And the Process Quote Button:

<!-- ship-to_form //-->
  <tr>
    <td>
    <?php echo tep_draw_form ('est_shipping_id', tep_href_link (FILENAME_SHIP_ESTIMATOR, 'action=process', 'SSL'), 'post')// . tep_draw_hidden_field('action', 'process'); ?>
    <table border="0" width="100%" cellspacing="1" cellpadding="2" class="infoBox">
	  <tr class="infoBoxContents">
	    <td><table border="0" width="100%" cellspacing="0" cellpadding="2">
		  <tr>
		    <td colspan=2 class="main"><b><?php echo TITLE_SHIPPING_ADDRESS; ?></b></td>
		  </tr>
		  <tr>
		    <td class="infoBoxContents"><?php echo ENTRY_POST_CODE; ?></td>
		    <td class="infoBoxContents"><?php echo tep_draw_input_field ('shippostcode') . ' ' . (tep_not_null(ENTRY_POST_CODE) ? '<span class="inputRequirement">* Required</span>': ''); ?></td>
		  </tr>
		  <tr>
		    <td class="infoBoxContents"><?php echo ENTRY_COUNTRY; ?></td>
		    <td class="infoBoxContents"><?php echo tep_get_country_list ('shipcountry',DEFAULT_COUNTRY) . ' ' . (tep_not_null(ENTRY_COUNTRY_TEXT) ? '<span class="inputRequirement">* Required</span>': ''); ?></td>
		  </tr>
		    <td class="infoBoxContents"></td>
		    <td class="infoBoxContents"><?php echo tep_image_submit ('button_process_quote.gif', IMAGE_BUTTON_PROCESS_QUOTE); ?></td>
		  </tr>
	    </table></td>
	  </tr>
	  <tr>
	   <td width="10"><?php echo tep_draw_separator ('pixel_trans.gif', '10', '1'); ?></td>
	   </tr>
    </table></form></td>
  </tr>
<!-- ship-to_form_eof //-->

Can these buttons be changed to the new style?

-Varina

[kymation]

You can change the buttons, but they depend on the jQuery code in the head, so you'll have to add that as well. I just converted the whole popup page by replacing the head section with a call to template_top.php. See the instructions here.

Regards
Jim

[varina]

Thanks for the link Jim. I am muddling through it. But since it is a pop up window I don't really need the heading info, (logo, cart buttons...) Can I put the jquery info in without calling for template_top.php?

[kymation]

You're right, that won't work. I forgot about the header part. Yes, you can add the jQuery and jQuery UI links to the head section of that page.

Regards
Jim

[varina]

kymation, on 18 February 2012, 23:00, said:

You're right, that won't work. I forgot about the header part. Yes, you can add the jQuery and jQuery UI links to the head section of that page.

Regards
Jim

Yep, I could, if I knew how...
Maybe I should just give up and stick with the old buttons...blue and grey isn't that bad right?

[kymation]

OK, I can help with this. Here's the files for 2.3.1 with Theme Switcher installed. If you're using the older version of Theme Switcher, add back the two lines of jQuery links, like you have in your template_top.php. If you have the latest version, this should work out of the box. This is only the two popup files, not all of the supporting stuff, since I haven't had time to fix up a release.

Regards
Jim