Hello people,
I'm just getting the hang of Github! But before I start making changes and pushing them back into the repository I have a simple question. If I was working on something that needed user interaction. Say I was working on the admin categories section and I wanted to add a button that allowed you to delete an image if one had been uploaded for that category.
Would people prefer if I got the code working using a crappy looking button and then simply came back later and made any buttons and other interface elements look nice later? It is the way I normally work. First get the code working and then go back and clean up the interface.
But if people want me to do everything before I push something back into the repository I will do that instead. Also is their anywhere on Github that lists what people are working on? I know we have the issue tracker but that's not linked to our Github accounts.
Latest News: (loading..)
0
Working with Github
Started by Jon86, Nov 05 2009, 12:25
3 replies to this topic
#3
Posted 07 November 2009, 23:39
The issue tracker can be found at http://svn.oscommerce.com/jira/secure/Dashboard.jspa
I would suggest that you work on any changes in your github using the methods you are most comfortable with as this naturally makes the whole process smoother. If there are any changes you would like to see put into the core of osCommerce then please be sure to make the code as complete as possible. Opening an issue in the issue tracker for any changes you would like to see merged in with details of what the change does etc would also be very useful as we go through and look at open issues. Looking at how the code is formatted would also be good to ensure you keep as close to our coding standards as possible.
I would suggest that you work on any changes in your github using the methods you are most comfortable with as this naturally makes the whole process smoother. If there are any changes you would like to see put into the core of osCommerce then please be sure to make the code as complete as possible. Opening an issue in the issue tracker for any changes you would like to see merged in with details of what the change does etc would also be very useful as we go through and look at open issues. Looking at how the code is formatted would also be good to ensure you keep as close to our coding standards as possible.
Mark Evans
osCommerce Monkey & Lead Guitarist for "Sparky + the Monkeys" (Album on sale in all good record shops)
---------------------------------------
Software is like sex: It's better when it's free. (Linus Torvalds)
osCommerce Monkey & Lead Guitarist for "Sparky + the Monkeys" (Album on sale in all good record shops)
---------------------------------------
Software is like sex: It's better when it's free. (Linus Torvalds)
#4
Posted 09 November 2009, 00:23
Yeah I have kept to your coding standards so its consistent when you read it for the few minor fixes I've been working on. When opening a new issue for a feature will I use the issue tracker you linked to their and simply ignore this one http://github.com/osCommerce/oscommerce/issues
