4 replies to this topic

[Gergely]

Hi,

Some contribution be constucted in this topic. Collect them.

[musicman3]

Hi Gergely   ! I have noticed a problem with taxes. At tax addition in Admin Tools - "Configuration-Configuration-My Store-Displayed the price with the tax-True". The new goods in Index.php. I am displayed with the price without the tax. In Box-New Products all OK. In Viewed products the price without the tax. In a trash can of the buyer all OK - with the tax. You thought as to correct it?

Edited by musicman3, 27 August 2009 - 08:47 AM.

[musicman3]

I have noticed that this problem is connected with "Products Variant". In Admin Tools-Content-Add Products-click name Products - price ZERO $ (0 $). Only this goods have a problem with display of taxes. The goods without Variants display the price in Admin Tools. Also the goods with the tax do not display an all-round price in Admin Tools. It is similar to the general problem with taxes for Variant Products.

[Gergely]

musicman3, on Aug 27 2009, 05:17 PM, said:

I have noticed that this problem is connected with "Products Variant". In Admin Tools-Content-Add Products-click name Products - price ZERO $ (0 $). Only this goods have a problem with display of taxes. The goods without Variants display the price in Admin Tools. Also the goods with the tax do not display an all-round price in Admin Tools. It is similar to the general problem with taxes for Variant Products.

Ok. I try to find in source tomorrow.

[Koeroesi86]

musicman3, on 27 August 2009 - 03:17 PM, said:

I have noticed that this problem is connected with "Products Variant". In Admin Tools-Content-Add Products-click name Products - price ZERO $ (0 $). Only this goods have a problem with display of taxes. The goods without Variants display the price in Admin Tools. Also the goods with the tax do not display an all-round price in Admin Tools. It is similar to the general problem with taxes for Variant Products.

It is a bug, and I've a small, but powerful solution:

add this function to the catalog/includes/classes/product.php:

function getVariantMinPriceTaxClass() {
	  $price = null;
	  $tax_id = null;

	  foreach ( $this->_data['variants'] as $variant ) {
		if ( ($price === null) || ($variant['data']['price'] < $price) ) {
		  $price = $variant['data']['price'];
		  $tax_id = $variant['data']['tax_class_id'];
		}
	  }

	  return ( $tax_id !== null ) ? $tax_id : 0;
}

mod the getPriceFormated function with this:

next to the if( $this->hasVariants() ) {, about #line 240

Original:

$price = $osC_Currencies->displayPrice($this->getVariantMinPrice(), $this->_data['tax_class_id']) . ' =>! ';

New:

$price = $osC_Currencies->displayPrice($this->getVariantMinPrice(), $this->getVariantMinPriceTaxClass()) . ' =>! ';

Hope this will be in the next release...

Cheers: Chris