3897 replies to this topic

[FunDMental]

""Also you say that 2.1 continued to work yet you say the include in application_top.php for the seo.class.php doesn't exist, this simply cant happen.""

Actually, I said version 2.1 Didn't work, it's been turned off since long before I started working on the site.
Whenever it was turned on you just got 404 errors for weird html files that didn't exist.


Every time I've tried to make any changes on this mess, I run into brick walls,  most of the time I'm able to figure out how to make things work.

can you at least tell me what parts of the scripts handle redirects, so maybe I can hunt down the issue?  the urls appear to be correct when I hover the cursor over a product, but something is getting lost in some kind of redirect.  The only place I can find any redirects in the stuff I had to edit is in application top, and I even went back to a clean App top file, and still get the same redirect error

[FWR Media]

FunDMental, on 19 July 2011 - 10:06 PM, said:

""Also you say that 2.1 continued to work yet you say the include in application_top.php for the seo.class.php doesn't exist, this simply cant happen.""

Actually, I said version 2.1 Didn't work, it's been turned off since long before I started working on the site.
Whenever it was turned on you just got 404 errors for weird html files that didn't exist.


Every time I've tried to make any changes on this mess, I run into brick walls,  most of the time I'm able to figure out how to make things work.

can you at least tell me what parts of the scripts handle redirects, so maybe I can hunt down the issue?  the urls appear to be correct when I hover the cursor over a product, but something is getting lost in some kind of redirect.  The only place I can find any redirects in the stuff I had to edit is in application top, and I even went back to a clean App top file, and still get the same redirect error

Redirect issues are almost always related to an incorrectly set up configure.php file, read back a few posts.

[FunDMental]

thanks, that helps narrow things down some

[omulec]

Guys, I would appreciate strong help.

I've installed YMM module, that is a kind of filter box rewritten for 2.3.1. With many problems with it finally after some modifications found over the support thread I managed to have it working. The issue is that the module once used for filtering adds to the path ?Make="make"&Model="model"&Year="year". As far as it's working in the main shop catalog SEO is not changing the url. But when you enter into any category SEO adds it's name to the path splitting the path between index.php and the part of the path added by YMM. The result is that the call for SQL is broken.

You can see such action here.

If anyone could support me how to change that (if it's possible at all), I would appreciate.

[FunDMental]

Thanks FWR for all the help, it's seriously appreciated.  I found at least part of my problem,  the previous idiot to work on these scripts (I'm the current idiot) didn't follow the instructions very well, and instead of replacing some of the code, she commented the old stuff out and pasted below. This wouldn't have been a problem if she'd been consistent but some she replaced, some she commented out and pasted below,  so I'm thinking at least a couple places I pasted your new code over code that had been commented out, which would definitely break a lot of things

The redirect errors are now gone, and the site is fully functional with SEO urls turned off, but when I turn them on, product info pages are blank and the url just says product_info.php

I know it's not a problem with the contribution, too many ppl are using it with no problem, so my question is,  do you have any idea where I may have messed up?  I'd really hate to go through the whole "go back to backups and reinstall" thing again if it can be avoided.

I really do appreciate the help, and as soon as i have some cash in my paypal to donate I plan to give to the cause

[FWR Media]

FunDMental, on 20 July 2011 - 12:39 AM, said:

The redirect errors are now gone, and the site is fully functional with SEO urls turned off, but when I turn them on, product info pages are blank and the url just says product_info.php

Are you able to PM me a link to the site in question?

[FWR Media]

omulec, on 19 July 2011 - 11:44 PM, said:

If anyone could support me how to change that (if it's possible at all), I would appreciate.

Hi this doesn't look like the problem is related to USU5 at all, it looks like an issue with the SQL query being built in another script.

E.g. the url is: -
index.php/wina-czerwone-c-1?Make=Piemont&Model=BaroloDOCG&Year=2004

Which is perfectly valid so USU5 is doing its job, but the result is: -

You have an error in your SQL syntax; check the manual that corresponds  to your MySQL server version for the right syntax to use near ') and   p.products_status = '1' and p.products_id = p2c.products_id and  pd.produc' at line 1

So you need to find out what the complete query looks like and why it is wrong. Either way it is not a support issue for this contribution.

Edited by FWR Media, 20 July 2011 - 07:37 AM.

[omulec]

FWR Media, on 20 July 2011 - 07:36 AM, said:

Hi this doesn't look like the problem is related to USU5 at all, it looks like an issue with the SQL query being built in another script.

E.g. the url is: -
index.php/wina-czerwone-c-1?Make=Piemont&Model=BaroloDOCG&Year=2004

Which is perfectly valid so USU5 is doing its job, but the result is: -

You have an error in your SQL syntax; check the manual that corresponds  to your MySQL server version for the right syntax to use near ') and   p.products_status = '1' and p.products_id = p2c.products_id and  pd.produc' at line 1

So you need to find out what the complete query looks like and why it is wrong. Either way it is not a support issue for this contribution.

Thanks for quick reaction.

I'm not saying that it's an issue generated by USU5, which without the YMM is working well (standard, rewrite is not supported by the hosting). YMM standalone is working also fine (well, with all the regards to the creators, it's the only free filter I've found for 2.3.1). I think that the issue is related to the fact that YMM may filter several parts of the shop - new products, specials, search result, catalog and categories.

For most of those purposes SEO link looks simple: catalog - index.php, new products - products_new.php, etc. When entering to any category the url changes due to a proper USU5 reaction into the one containing already the category name:
ex.: http://www.cantine.pl/sklep/index.php/wina-czerwone-c-1

This seems to be a no-go for YMM filter. It seems that it's not able to filter such page. Once I disable USU5, the YMM filter works also here without the error. I think that the solution might be to switch off somehow USU for categories, keeping them on product urls. But I don't think there is an option for that, is it?

I think that code responsible for that SQL error is inside index.php, added by YMM. But I'm not a coder, almost blind there, so I don't know if YMM code could be modified to have them working both USU5 and YMM. And unfortunately I don't think I will get some support from YMM thread here.

The part of index.php:

// show the products of a specified manufacturer

if (isset($HTTP_GET_VARS['manufacturers_id'])) {
	  if (isset($HTTP_GET_VARS['filter_id']) && tep_not_null($HTTP_GET_VARS['filter_id'])) {
// We are asked to show only a specific category
		$listing_sql = "select " . $select_column_list . " p.products_id, p.manufacturers_id, p.products_price, p.products_tax_class_id, IF(s.status, s.specials_new_products_price, NULL) as specials_new_products_price, IF(s.status, s.specials_new_products_price, p.products_price) as final_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_MANUFACTURERS . " m, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c where " . (YMM_FILTER_PRODUCT_LISTING == 'Yes' ? $YMM_where : '') . " p.products_status = '1' and p.manufacturers_id = m.manufacturers_id and m.manufacturers_id = '" . (int)$HTTP_GET_VARS['manufacturers_id'] . "' and p.products_id = p2c.products_id and pd.products_id = p2c.products_id and pd.language_id = '" . (int)$languages_id . "' and p2c.categories_id = '" . (int)$HTTP_GET_VARS['filter_id'] . "'";
	  } else {
// We show them all
		$listing_sql = "select " . $select_column_list . " p.products_id, p.manufacturers_id, p.products_price, p.products_tax_class_id, IF(s.status, s.specials_new_products_price, NULL) as specials_new_products_price, IF(s.status, s.specials_new_products_price, p.products_price) as final_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_MANUFACTURERS . " m where " . (YMM_FILTER_PRODUCT_LISTING == 'Yes' ? $YMM_where : '') . " p.products_status = '1' and pd.products_id = p.products_id and pd.language_id = '" . (int)$languages_id . "' and p.manufacturers_id = m.manufacturers_id and m.manufacturers_id = '" . (int)$HTTP_GET_VARS['manufacturers_id'] . "'";
	  }
	} else {
// show the products in a given categorie
	  if (isset($HTTP_GET_VARS['filter_id']) && tep_not_null($HTTP_GET_VARS['filter_id'])) {
// We are asked to show only specific catgeory
		$listing_sql = "select " . $select_column_list . " p.products_id, p.manufacturers_id, p.products_price, p.products_tax_class_id, IF(s.status, s.specials_new_products_price, NULL) as specials_new_products_price, IF(s.status, s.specials_new_products_price, p.products_price) as final_price from " . TABLE_PRODUCTS . " p left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id, " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_MANUFACTURERS . " m, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c where " . (YMM_FILTER_PRODUCT_LISTING == 'Yes' ? $YMM_where : '') . " p.products_status = '1' and p.manufacturers_id = m.manufacturers_id and m.manufacturers_id = '" . (int)$HTTP_GET_VARS['filter_id'] . "' and p.products_id = p2c.products_id and pd.products_id = p2c.products_id and pd.language_id = '" . (int)$languages_id . "' and p2c.categories_id = '" . (int)$current_category_id . "'";
	  } else {
// We show them all
		$listing_sql = "select " . $select_column_list . " p.products_id, p.manufacturers_id, p.products_price, p.products_tax_class_id, IF(s.status, s.specials_new_products_price, NULL) as specials_new_products_price, IF(s.status, s.specials_new_products_price, p.products_price) as final_price from " . TABLE_PRODUCTS_DESCRIPTION . " pd, " . TABLE_PRODUCTS . " p left join " . TABLE_MANUFACTURERS . " m on p.manufacturers_id = m.manufacturers_id left join " . TABLE_SPECIALS . " s on p.products_id = s.products_id, " . TABLE_PRODUCTS_TO_CATEGORIES . " p2c where " . (YMM_FILTER_PRODUCT_LISTING == 'Yes' ? $YMM_where : '') . " p.products_status = '1' and p.products_id = p2c.products_id and pd.products_id = p2c.products_id and pd.language_id = '" . (int)$languages_id . "' and p2c.categories_id = '" . (int)$current_category_id . "'";
	  }
	}

Where added in the original code is only

" . (YMM_FILTER_PRODUCT_LISTING == 'Yes' ? $YMM_where : '') . " 

in all 4 lines

[FWR Media]

omulec, on 20 July 2011 - 08:23 AM, said:

Thanks for quick reaction.

I'm not saying that it's an issue generated by USU5, which without the YMM is working well (standard, rewrite is not supported by the hosting). YMM standalone is working also fine (well, with all the regards to the creators, it's the only free filter I've found for 2.3.1). I think that the issue is related to the fact that YMM may filter several parts of the shop - new products, specials, search result, catalog and categories.

I support USU5 here but not other contributions so I am afraid I cannot help.

[omulec]

FWR Media, on 20 July 2011 - 08:47 AM, said:

I support USU5 here but not other contributions so I am afraid I cannot help.

Any possibility/suggestion than to switch off USU5 on category URLs?

Anyway, thanks Robert. For both - contributions and being present in the support thread.

[FWR Media]

omulec, on 20 July 2011 - 08:57 AM, said:

Any possibility/suggestion than to switch off USU5 on category URLs?

Anyway, thanks Robert. For both - contributions and being present in the support thread.

Hacking and thereby breaking the working functionality of USU5 is not the correct approach, the correct approach is to repair the script that is broken.

[Backcountry_Surfer]

Right - Here we go ...

Finished installation with no errors this time. However when I go into my admin panel my SEO URLs looks different to the operation file included? Mine reads:

SEO URLs
Enable SEO URLs?
Choose URL Type
Cache Directory
Compress SEO Cache File

whereas the instructions show:

SEO URLs 5
Enable SEO URLs
Enable the cache
Enable multi language support
Output W3C valid URIs
Select your chosen cache system ... etc etc and so on

So I cant follow the settings?


What am I missing? Whats my name? and where can I procure a new brain to figure this out? or am I being a doofus? (these are all Rhetorical of course) After seeing what I did wrong last time I have to say that although this is not working for me it was such an easy to follow contrib. Now it could be that when I first started this online shop a long long time ago when my coding skills where even less than I know now, I may have tried an old version but couldn't get it to work which was the case so many times back then. So I may have left something from that contrib? Help me FWR Canobi, your my only hope!


Thanks in advance for any light you can shed on the matter!

Cheers
Danny

[FWR Media]

Backcountry_Surfer, on 20 July 2011 - 03:23 PM, said:

Right - Here we go ...

Finished installation with no errors this time. However when I go into my admin panel my SEO URLs looks different to the operation file included? Mine reads:

Hi Danny

Those are settings from an old version of seo urls by Chemo.

It shouldn't matter though. As soon as you run the front of the site USU5 deletes any old residual seo urls settings and replaces with the new.

Try closing all browsers .. visit the front of the site .. then viewing admin again.

[Backcountry_Surfer]

Thanks for the lightning response.

I think I will have to back track all I have done this time round and double check although I am certain I made no mistakes this time round? I tried as you suggested to close all browsers etc (on 3 different computers) with no luck?! Totally baffled ...

Before I start all that, could it be anything else at all that maybe causing some kind of conflict? I know its virtually impossible for you to just pluck out a solution to any and all problems that may occur but, seeing as this should have deleted any old version I just dont know where to start?

Thanks
Danny

[Backcountry_Surfer]

Really back-tracked now, found some of the original code from a year ago still embedded from the Chemo version USU v1.0 Must of just left that in there for a laugh? I know you said it shouldn't make a difference but, something is wrong so I have tried flushing out all of that code and I found the seo_cache, install-seo and reset_seo_cache php files still in there! Oh well - gone now.

Just the 5 images to delete as well from the image folder to with that contribution. Now, when I look at my admin it still reads:

SEO URLs
Enable SEO URLs?
Choose URL Type
Cache Directory
Compress SEO Cache File

How come this is still there? where would that be to delete?

Danny

[don01234]

I just notice following error on my catalog/products_new.php page:

Catchable fatal error: Argument 1 passed to aPage_Modules::linkText() must be an array, null given, called in /catalog/includes/modules/ultimate_seo_urls5/page_modules/product_info.php on line 170 and defined in /catalog/includes/modules/ultimate_seo_urls5/abstracts/page_modules.php on line 338

did anyone else had this problem?  

I have OSc v 2.3.1 & Ultimate Seo Urls 5 PRO

Don

[FWR Media]

don01234, on 23 July 2011 - 02:54 PM, said:

I just notice following error on my catalog/products_new.php page:

Catchable fatal error: Argument 1 passed to aPage_Modules::linkText() must be an array, null given, called in /catalog/includes/modules/ultimate_seo_urls5/page_modules/product_info.php on line 170 and defined in /catalog/includes/modules/ultimate_seo_urls5/abstracts/page_modules.php on line 338

did anyone else had this problem?  

I have OSc v 2.3.1 & Ultimate Seo Urls 5 PRO

Don

Product_Info_Page_Module::acquireLinkText() is returning null which means that the products_id being being passed in does not return the required array of results from the database.

[museumreplicas.gr]

Hi, I am using Ultimate seo urls 5 r197 on oscommerce 2.2 and I'd like to add the Greek language, could you send me the greek character conversion file as well?
Thank you
Agis

[museumreplicas.gr]

artstyle, on 17 April 2011 - 03:33 PM, said:

Hi,
Thank you very much for this contribution.
I installed it in a test folder on my site as I am trying to upgrade smoothly to OsCommerce 2.3.1.
I have English and Greek languages installed.
The contribution works perfectly with the english side of my site. When I switch to Greek it still shows only english urls. I have set enable multi language support to true and I have uploaded bm_languages file from the additional uploads folder. I added a greek.php file in character conversion folder.
Is there anything else I have to do?
Thank you in advance,

Hi Alexandra, I'm using Ultimate seo urls 5 r197 on oscommerce 2.2 and I'm having the same problem here, though I haven't added a Greek character conversion file.
Did you find a solution on this?

[FWR Media]

museumreplicas.gr, on 26 July 2011 - 12:28 PM, said:

Hi Alexandra, I'm using Ultimate seo urls 5 r197 on oscommerce 2.2 and I'm having the same problem here, though I haven't added a Greek character conversion file.
Did you find a solution on this?

Assuming that English is the default language,  you have a language set up in admin as "gr" ( code field of the languages table ) and that you have turned on multi language support then ..

www.mysite.com/index.php would load the English links and language.

www.mysite.com/index.php/gr would load Greek