79 replies to this topic

[psylencer]

Auctions Contrib has been completely re-developed.  Please see here :http://addons.oscommerce.com/info/5890

Auctions 2.1 By Dan Herlihy for OSCommerce Version 2.2rc2a (Should work on previous versions)

Credit goes to Celdish, Marcus Design, Azer and The French Autions team. Who have all put a lot of work into this contrib.
I'd also like to thank those who tested and reported bugs for the BETA Version of this contribution. Without your help, this
would not have been possible.

Regards
Dan

TESTED with PHP V5

Basic Features :
Run your own ebay Like auctions from your own website.
Admin console to monitor the status of auctions (Auction finished, added to cart, complete).
Auto emails sent upon higher bid and finished auction.
Finished Auctions automatically added to users shopping cart.
Auctions page provides overview of current auctions including number of bidders, starting bid, highest bid, time remaining,

etc.
Current auctions of which a user has bid on appear in "My Account" (account.php)
PHP countdown with autorefresh to update times
PHP file for CRON job to automatically process completed auctions, sends notification emails, adds to cart etc.  

***Please note, completed auctions are processed in the following ways:
• CRON JOB (you must set this up yourself - Google VisualCron (for windows) for more information. This cron job is best run

from the server in which your site resides. Ask your system Admin about setting up a "CronJob" to automatically load the

aucron2.php file every 3 or so mins.
• Customer views their own shopping cart
• Anyone views the completed auction page (This page will auto refresh which will also process a completed auction)



Installation Notes:

This installation requires a basic level of PHP and SQL understanding provided you are installing this on a fresh copy of

OSC version 2.2rc2a
You can modify the "results per page" for the auctions.php and account.php by changing the value of the $rowsPerPage

variable in each page.
Please ensure the following files are modified to suit your store.  You will need to replace "Yoursitename.com" and "Your

Name" with your own details.  This (Best done once installation is complete)
catalog/includes/modules/auctions_bids.php
catalog/shopping_cart.php
catalog/product_info.php
You must set a cron job to execute aucron2.php file every 3 mins.  This file will automatically detect finished auctions and

send emails to the winners.

[azer]

please
as i already told you dont open a new contribution page for each version of your auction contribution
first there was already one and you wrote it was the last package there you didnt understand that even if you rewrite completly the code since you took the original code there you should post there

second you open a 2.0 beta and now a 2.10 , do you think to open again a page for 2.20, 2.30 ?

incredible and not easy for member to follow you


so as adviced stick to http://addons.oscommerce.com/info/4651

and ask the team to delete you other contrib page

take my advice as a rule please

Edited by azer, 22 April 2008 - 07:42 AM.

[chooch]

I have to agree with Azer on this...

There was no need to open up a new contribution everytime a modification is made - the last two instances of you adding a new independent contribution to the downloads are was not necessary..... you should have used a little tact because this will end up being confusing for some people who are looking a for a particular type of auction contribution to download.

I suggest asking a moderator to delete this contributions you have added:
Auctions V2 Beta http://addons.oscommerce.com/info/5843

It is prefereable to continue adding contribution modifications at the original area:
http://addons.oscommerce.com/info/4651 and preferable to use the original support thread: http://forums.oscommerce.com/index.php?showtopic=235920

But as it seems you are trying to break away from the style of the original author with modifications and have set up your own download with a new support thread, I request you continue to post all updates in just one area which is here: http://addons.oscommerce.com/info/5890

Thanks

Edited by chooch, 22 April 2008 - 11:34 AM.

[psylencer]

chooch, on Apr 22 2008, 11:31 AM, said:

I have to agree with Azer on this...

There was no need to open up a new contribution everytime a modification is made - the last two instances of you adding a new independent contribution to the downloads are was not necessary..... you should have used a little tact because this will end up being confusing for some people who are looking a for a particular type of auction contribution to download.

I suggest asking a moderator to delete this contributions you have added:
Auctions V2 Beta http://addons.oscommerce.com/info/5843

It is prefereable to continue adding contribution modifications at the original area:
http://addons.oscommerce.com/info/4651 and preferable to use the original support thread: http://forums.oscommerce.com/index.php?showtopic=235920

But as it seems you are trying to break away from the style of the original author with modifications and have set up your own download with a new support thread, I request you continue to post all updates in just one area which is here: http://addons.oscommerce.com/info/5890

Thanks

Before you go and hop on Azers band wagon, have a look at my code, have a look how much SH*T has been removed and added in its place. Doing so was a request from those actively involved in the contrib.  This is not simply a 5 second bunch of mods, rather the culmination of ALL previous issues, requested functions etc from the previous contrib.  ALL features no one else here could be F**KED completing.   Separating the two was not a decision based on removing credit from original authors, rather to limit confusion from those seeking advice or reading now completely obsolete posts on fixes from previous versions. Note to mention the 11 odd pages of advice of which 95% of has been rectified in this contrib.

I invite you to go back, have a look at the outstanding issues from the previous thread, issues which you'll find from page 1-11.  Now I invite you to go back and find one that hasn't been rectified in this contrib.

As for Azers completely STUPID comment about opening a new thread for version 2.2,3 etc. Azer WAKE UP.  Having NO ONE to test this contrib bar myself, i did not want an in opperable version to be muddled in amoungst finished versions.  HENCE THE WORD B-E-T-A! Meaning (in IT terms) "Testing for BUGS".  Shall we just add all the obsolete feedback to the original thread as well?  

I should point out that separating this contribution was done under advice from people ACTIVELY contributing and submitting feedback on the BETA version, something none of you guys would do.  

Its taken years for someone to be bothered getting off their ass to develop this contrib into something truely useful.
A simple thankyou for all the hard work would suffice.


Dan

Edited by psylencer, 23 April 2008 - 09:19 AM.

[azer]

well then that would be great to call it something diferent from the beginnig like :

Better auctions or anything , but not auction 2.xx that for sure would evolve to auction 3.xx sometimes
so not use any version in the name
And for me as it s an evolution of auction i dont see the meaning to post it in another page even if it s a tremendous evolution, it s just to not confuse osc members and to get as much help as you need bu people interested in this contributions.

Making different threads, different contrib page, different names would only split people and make them being confused.

Quote

Quote

please
as i alredy told you dont open a new contribution page for each version of your auction contribution
first there was already one and you worte it was the last package there you didnt understand that even if you rewrite completly the code since you took the original code there you should post there

second you open a 2.0 beta and now a 2.10 , do you think to open aain a page for 2.20, 2.30 ?

incredible and not easy for member to folow you


so as adviced stick to http://addons.oscommerce.com/info/4651

and ask the team to delete you other contrib page

take my advice as a rule please as i know already contributor having all their work and contrib deleted in the past for this kind of behaviour

This contrib is so far removed from the original that it is not practical to have the two together.  Separating the two has been a request from those ACTIVELY involved in this contrib for this reason.  I have already requested the BETA contrib be removed, I certainly don't need, advise on the subject. Ill not be doing the same for Version 2.1 which is polished *enough* to release as THE ONLY fully functional version.

Dan

[psylencer]

azer, on Apr 23 2008, 11:08 AM, said:

well then that would be great to call it something diferent from the beginnig like :

Better auctions or anything , but not auction 2.xx that for sure would evolve to auction 3.xx sometimes
so not use any version in the name
And for me as it s an evolution of auction i dont see the meaning to post it in another page even if it s a tremendous evolution, it s just to not confuse osc members and to get as much help as you need bu people interested in this contributions.

Making different threads, different contrib page, different names would only split people and make them being confused.
This contrib is so far removed from the original that it is not practical to have the two together.  Separating the two has been a request from those ACTIVELY involved in this contrib for this reason.  I have already requested the BETA contrib be removed, I certainly don't need, advise on the subject. Ill not be doing the same for Version 2.1 which is polished *enough* to release as THE ONLY fully functional version.

Dan

I would have, however, much of the work was done by previous contributors, and, like I said, Credit.  Given the fact that I've requested the BETA version be removed as is no longer necessary. Given the fact, that nobody seems to look at the previous version or respond to any posts and the fact I've posted a notice in the previous version, stating I will not support it, I do not think this will be a problem.  If it is, people should learn to read. If they can't, I don't want to support them. Fair enough?

Edited by psylencer, 23 April 2008 - 01:57 PM.

[chooch]

Look, credit where it is due... I think it's great you are working on this contribution psylencer, I don't really want to make an issue about what I think you should or should not do - I simply aired an opinion.

I can see you have put much effort in to updating the contribution, anyway Auctions 2.1 By Dan Herlihy is a good enough place to put it as it minimises confusion with the original contribution.

Thanks

Edited by chooch, 23 April 2008 - 02:08 PM.

[azer]

and i would for sure not speak about my stupid comments ,  never talked about credits but rather a logic,
take a contrib like fckeditor, lookin contributions see they are at least 5 , so because i helped in one i ot at least 10 message a week asking me wich one to download, wich one is the best, wich one is the last, and i thin it s a waste of enrgy and time.

it think this is not stupid when i see auctions   then auction beta, then auction 2.10 and not auction 2 for instance
to say and expect that then after there will be a page 3.10 etc.

so before it was too late i wanted to give an advice and opinion.

by the way if i didnt test your version it s because i m already testing the beta version that also is a bunch of work we did with french members.

and i think when your beta is finished and ours , then we coulnd defintily make an even better version with both work.

imagine if we did alos a page calleld auction french beta , then for sure again ... blablab bla bla bla

so dont misunderstand me i dont judge your work as i know we also had to rework almost from the scratch and it s hard to work at several on a complete rework of any code ...

i for sur would give you feedback when i would test your new version on a virgin ms2

so stupid and french, but not dumb and deaf
that would be my last post about this subject  

[echolalia]

Firstly thank you Dan for a great contribution.

Let's hope we can get this forum back to the original topic - support for Auction v2.1.

I just uploaded a out of the box package of OS Commerce and installed Auction v2.1. It works great, however for a few little bugs.

The first being:

Page -
http://domain.com.au/auctions.php

The error display twice, under the Starting Price and Highest Bid

Warning: Missing argument 2 for display_price() in /var/www/vhosts/domain.com.au/httpdocs/includes/classes/currencies.php on line 72

I know there is no modifications for the currencies file.

Line 72 is

	function display_price($products_price, $products_tax, $quantity = 1) {
	  return $this->format($this->calculate_price($products_price, $products_tax, $quantity));
	}

The second error is in:
http://domain.com.au/product_info.php?products_id=8

Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/domain.com.au/httpdocs/product_info.php:142) in /var/www/vhosts/domain.com.au/httpdocs/product_info.php on line 160

Line 142 in product_info.php is

<html <?php echo HTML_PARAMS; ?>>

And line 160 is:

159 if ($casprodid==(int)$HTTP_GET_VARS['products_id']) {
160 header('Refresh: 90');} else {
161 echo '';}

I haven't had a chance to go over the code fully to see what could be causing the errors.
Like I said before, I am using the out of the box installation. The sql file was installed.
The admin works without any problems.

Thanks in advance!
Lau

[psylencer]

azer, on Apr 23 2008, 10:10 PM, said:

and i would for sure not speak about my stupid comments ,  never talked about credits but rather a logic,
take a contrib like fckeditor, lookin contributions see they are at least 5 , so because i helped in one i ot at least 10 message a week asking me wich one to download, wich one is the best, wich one is the last, and i thin it s a waste of enrgy and time.

it think this is not stupid when i see auctions   then auction beta, then auction 2.10 and not auction 2 for instance
to say and expect that then after there will be a page 3.10 etc.

so before it was too late i wanted to give an advice and opinion.

by the way if i didnt test your version it s because i m already testing the beta version that also is a bunch of work we did with french members.

and i think when your beta is finished and ours , then we coulnd defintily make an even better version with both work.

imagine if we did alos a page calleld auction french beta , then for sure again ... blablab bla bla bla

so dont misunderstand me i dont judge your work as i know we also had to rework almost from the scratch and it s hard to work at several on a complete rework of any code ...

i for sur would give you feedback when i would test your new version on a virgin ms2

so stupid and french, but not dumb and deaf
that would be my last post about this subject  

The Beta IS finished .  2.1 is a polished version, sure there is plenty of work to do, however this version is fully functional.  I've already got a list of improvements in terms of functionality, Language definition files, streamlining code and very minor bug fixes.

[psylencer]

echolalia, on Apr 24 2008, 01:32 AM, said:

Firstly thank you Dan for a great contribution.

Let's hope we can get this forum back to the original topic - support for Auction v2.1.

I just uploaded a out of the box package of OS Commerce and installed Auction v2.1. It works great, however for a few little bugs.

The first being:

Page -
http://domain.com.au/auctions.php

The error display twice, under the Starting Price and Highest Bid

Warning: Missing argument 2 for display_price() in /var/www/vhosts/domain.com.au/httpdocs/includes/classes/currencies.php on line 72

I know there is no modifications for the currencies file.

Line 72 is

	function display_price($products_price, $products_tax, $quantity = 1) {
	  return $this->format($this->calculate_price($products_price, $products_tax, $quantity));
	}

The second error is in:
http://domain.com.au/product_info.php?products_id=8

Warning: Cannot modify header information - headers already sent by (output started at /var/www/vhosts/domain.com.au/httpdocs/product_info.php:142) in /var/www/vhosts/domain.com.au/httpdocs/product_info.php on line 160

Line 142 in product_info.php is

<html <?php echo HTML_PARAMS; ?>>

And line 160 is:

159 if ($casprodid==(int)$HTTP_GET_VARS['products_id']) {
160 header('Refresh: 90');} else {
161 echo '';}

I haven't had a chance to go over the code fully to see what could be causing the errors.
Like I said before, I am using the out of the box installation. The sql file was installed.
The admin works without any problems.

Thanks in advance!
Lau

Thanks for the feedback.  

I'll go through them one by one.

Currencies? Yes you are correct here.  I will make this mod in the next version 2.2


Line 72 is

	function display_price($products_price, $products_tax, $quantity = 1) {
	  return $this->format($this->calculate_price($products_price, $products_tax, $quantity));
	}

The missing argument for display price is for TAX.  as I did not want tax to be applied or come into play when people are bidding on items, I left out the argumet.  This error can be ignored, short of that, I'll have to re-do the function.

Line 142 in product_info.php is

<html <?php echo HTML_PARAMS; ?>>

And line 160 is:

159 if ($casprodid==(int)$HTTP_GET_VARS['products_id']) {
160 header('Refresh: 90');} else {
161 echo '';}

I could not reproduce this error on Version 2.2 RC2a.  This section of code however is to automatically refresh the page every 90secs.  The error displayed is definitely being caused by header tags being sent twice to the page.  Any chance you could PM me your product_info.php so I can try to reproduce the error?


Regards
Dan

[dbz_195]

i have a moded site!! which file do i upload "Catalog_NEW_AND_MODIFIED FILES" or "Catalog_NEW_FILES"

[echolalia]

dbz_195, on Apr 26 2008, 03:06 AM, said:

i have a moded site!! which file do i upload "Catalog_NEW_AND_MODIFIED FILES" or "Catalog_NEW_FILES"

I believe (but this is my own personal opinion) that you upload Catalog_NEW_FILES and then mod all the additional files that is outlined in the read me / text file documentation.

Hope that helps

[psylencer]

dbz_195, on Apr 25 2008, 05:06 PM, said:

i have a moded site!! which file do i upload "Catalog_NEW_AND_MODIFIED FILES" or "Catalog_NEW_FILES"

Just the new files, the new and modded files are for install to a fresh un modded version of OSC

Dan

[psylencer]

Just a note to everyone.

Our auction site just got pulled because we don't have an auctioneers licence.  We'll be looking into this ASAP.

Im in Australia by the way.

Dan

[psylencer]

psylencer, on Apr 28 2008, 12:10 AM, said:

Just a note to everyone.

Our auction site just got pulled because we don't have an auctioneers licence.  We'll be looking into this ASAP.

Im in Australia by the way.

Dan

I've done my research.  Apparently there are no laws which prevent the sale of new items via auction in Australia.  UNLESS you are selling motor vehicles or Real Estate, or prescribed items (mobile phones and second hand goods)

Dan

[andyferriby]

Hiya. im trying to install Auctions V2.1 by Dan Herlihy but the SQL has an error somewhere!

Is there an updated SQL?

[echolalia]

andyferriby, on May 8 2008, 07:26 AM, said:

Hiya. im trying to install Auctions V2.1 by Dan Herlihy but the SQL has an error somewhere!

Is there an updated SQL?

Are you getting this error while trying to insert the SQL?
Or on a page when you are trying to generate something?

What is the error?

I am still having some issues as well. They are the ones mention above.

[andyferriby]

echolalia, on May 8 2008, 02:17 AM, said:

Are you getting this error while trying to insert the SQL?
Or on a page when you are trying to generate something?

What is the error?

I am still having some issues as well. They are the ones mention above.

Its installing the SQL onto my database

[andyferriby]

andyferriby, on May 8 2008, 12:05 PM, said:

Its installing the SQL onto my database

My SQL Server is running Version 4.0.30 and this is the SQL i need to go onto my database,

CREATE TABLE `auctions` (

  `auctions_id` int(11) NOT NULL auto_increment,

  `products_id` int(11) NOT NULL default '0',

  `auctions_starting_price` decimal(15,4) NOT NULL default '0.0000',

  `auctions_date_added` datetime default NULL,

  `auctions_last_modified` datetime default NULL,

  `expires_date` datetime NOT NULL default '2006-11-01 00:00:00',

  `date_status_change` datetime default NULL,

  `status` int(1) NOT NULL default '1',

  `overbid_amount` float(10,2) NOT NULL default '0.00',

  `notified` int(1) NOT NULL default '1',

  `auction_paid` int(1) NOT NULL default '1',

  `auctions_nb` int(5) unsigned zerofill default '00000',

  `auctions_max` decimal(15,2) default '0.00',

  `auctions_high_cust` int(15) default NULL,

  PRIMARY KEY  (`auctions_id`)

) ENGINE=MyISAM AUTO_INCREMENT=9 DEFAULT CHARSET=latin1 COLLATE=latin1_general_ci;



CREATE TABLE `auctions_bids` (

  `auctions_bids_id` int(11) NOT NULL auto_increment,

  `auctions_id` int(11) NOT NULL default '0',

  `customers_id` int(11) NOT NULL default '0',

  `bid_price` float(10,2) NOT NULL default '0.00',

  `bid_status` varchar(10) collate latin1_general_ci default NULL,

  `bid_date_added` datetime NOT NULL,

  PRIMARY KEY  (`auctions_bids_id`)

) ENGINE=MyISAM AUTO_INCREMENT=23 DEFAULT CHARSET=latin1 COLLATE=latin1_general_ci;





INSERT INTO `configuration` (`configuration_title`, `configuration_key`, `configuration_value`, `configuration_description`, `configuration_group_id`, `sort_order`, `last_modified`, `date_added`, `use_function`, `set_function`) VALUES ('End of Auction  - Options', 'AUCTION_END_OPTIONS', '1', 'How do you want your auctions to end, select an option: <br />0 - Auction goes inactive<br />1 - Auction remains active but can''t be bid on', 1984, 1, '2006-11-13 19:26:24', '2006-11-11 13:23:56', NULL, 'tep_cfg_select_option(array(''0'', ''1''), ');

INSERT INTO `configuration_group` (`configuration_group_id`, `configuration_group_title`, `configuration_group_description`, `sort_order`, `visible`) VALUES (1984, 'Auction Listing', 'All configuration settings for the auctions module should go here', 1984, 1);

ALTER TABLE customers_basket ADD auction_product int(1) NOT NULL default '0' /* Dans modification */

but i get an error that says:

Error

SQL-query :

CREATE TABLE `auctions` (
`auctions_id` int( 11 ) NOT NULL AUTO_INCREMENT ,
`products_id` int( 11 ) NOT NULL default '0',
`auctions_starting_price` decimal( 15, 4 ) NOT NULL default '0.0000',
`auctions_date_added` datetime default NULL ,
`auctions_last_modified` datetime default NULL ,
`expires_date` datetime NOT NULL default '2006-11-01 00:00:00',
`date_status_change` datetime default NULL ,
`status` int( 1 ) NOT NULL default '1',
`overbid_amount` float( 10, 2 ) NOT NULL default '0.00',
`notified` int( 1 ) NOT NULL default '1',
`auction_paid` int( 1 ) NOT NULL default '1',
`auctions_nb` int( 5 ) unsigned zerofill default '00000',
`auctions_max` decimal( 15, 2 ) default '0.00',
`auctions_high_cust` int( 15 ) default NULL ,
PRIMARY KEY ( `auctions_id` )
)ENGINE = MYISAM AUTO_INCREMENT =9DEFAULT CHARSET = latin1 COLLATE = latin1_general_ci

MySQL said:
#1064 - You have an error in your SQL syntax.  Check the manual that corresponds to your MySQL server version for the right syntax to use near 'DEFAULT CHARSET=latin1 COLLATE=latin1_general_ci' at line 33