Jump to content


Corporate Sponsors


Latest News: (loading..)

* * * * * 3 votes

[Contribution] oscThumb


434 replies to this topic

#141 osCommaniak

  • Community Member
  • 19 posts
  • Real Name:Maciej Nowak
  • Gender:Male
  • Location:Poland

Posted 01 June 2009, 10:25

View Postbobbzh, on Jun 1 2009, 11:05 AM, said:

Same thing on your site?
I had a problem with images in columns (left or right) when width of image exceeded width of the column. However, the problem disappeared. I will check it again.
Box 'What's new?' and 'Revievs' or 'Specials' uses the same display rule, so I think.
You suggesting that I have to set the size of main image (product image) on the 300? I did it.
Please note, that I have now version 1.1 of oscThumb, which exactly installed according to the information in the Install.html file.

Encrypt Image Filenames (with thumbnails and watermarks) is a essence feature of this contribution. There is no need to disable Encrypt Image Filenames option. ;)

#142 bobbzh

  • Community Member
  • 5 posts
  • Real Name:Bob Bzh

Posted 01 June 2009, 12:15

Thank you for your quick reply :)

Quote

I had a problem with images in columns (left or right) when width of image exceeded width of the column. However, the problem disappeared. I will check it again.
Yes, I mean I have this problem.
Did you check?
Just put a large image product, and post a review about it...

Quote

Box 'What's new?' and 'Revievs' or 'Specials' uses the same display rule, so I think.
You mean it's normal? Reviews box picture and Product picture must have the same width?

Quote

You suggesting that I have to set the size of main image (product image) on the 300? I did it.
No no, any size must be allowed of course, but I want to keep my 150px right column when I have a Product picture larger...

Quote

Encrypt Image Filenames (with thumbnails and watermarks) is a essence feature of this contribution. There is no need to disable Encrypt Image Filenames option.
Hehe, I agree with that, but I wanted to test without, if the problem come from that...

#143 osCommaniak

  • Community Member
  • 19 posts
  • Real Name:Maciej Nowak
  • Gender:Male
  • Location:Poland

Posted 01 June 2009, 12:35

View Postbobbzh, on Jun 1 2009, 02:15 PM, said:

Yes, I mean I have this problem.
Did you check?
Just put a large image product, and post a review about it...
Why do I think that review will change the way?
I wrote that the boxes 'What's new?' and 'Reviews' or 'Specials' uses the same display rule. If you have something bad in the 'Reviews', when it should be same in 'What's new?' and 'Specials', is not it? I noticed problem with large width of product image earlier. Today, I see that I have no problem. Check it out on the oscDemo.

View Postbobbzh, on Jun 1 2009, 02:15 PM, said:

You mean it's normal? Reviews box picture and Product picture must have the same width?
Of course, NO!

View Postbobbzh, on Jun 1 2009, 02:15 PM, said:

No no, any size must be allowed of course, but I want to keep my 150px right column when I have a Product picture larger...
^ check on my oscDemo.

View Postbobbzh, on Jun 1 2009, 02:15 PM, said:

Hehe, I agree with that, but I wanted to test without, if the problem come from that...
You can set the display of original images for other types, such as: logos, buttons, etc. Not checked this, but all images displayed in columns is probably one category. Encrypt Image Filenames option is rather allowed to test a whole.

#144 bobbzh

  • Community Member
  • 5 posts
  • Real Name:Bob Bzh

Posted 01 June 2009, 13:12

Thanks again,

I will surprise you, take a look on your demo site, I wrote a review and there is the same problem than on my site :)

http://www.novaxim.linuxpl.com/oscDemo/pro...p?products_id=1

So reviews box and what's new box use a different image...

#145 dodog

  • Community Member
  • 4 posts
  • Real Name:DodoG

Posted 08 June 2009, 14:04

Maciej, and what about Lightbox?

Is it possible to have oscThumb with Lighbox installed and working correctly?

#146 ricardodacosta

  • Community Member
  • 132 posts
  • Real Name:ricardo

Posted 10 June 2009, 19:16

Just tried to install this contribution and this is what is happening:


Parse error: syntax error, unexpected T_VARIABLE in /home/content/y/o/g/yogicchai/html/catalog/yogicchai/includes/application_top.php on line 683

// START oscThumb
  require(DIR_WS_CLASSES . 'oscthumb.php');
    $oscthumb = new oscthumb; (This is line 683)
    $oscthumb->check_hash(); // Check if parameters have changed. Delete cache if yes.
// END oscThumb

Any suggestions?

#147 osCommaniak

  • Community Member
  • 19 posts
  • Real Name:Maciej Nowak
  • Gender:Male
  • Location:Poland

Posted 11 June 2009, 09:51

View Postbobbzh, on Jun 1 2009, 11:05 AM, said:

I think I found a bug, thanks to confirm:

If you have a big product-information-image (300px for exemple) and have a review on this product, if you see the review on colomn_right when you are on the product page, both images have the same size, so right column is completely too large (300px).
I think, that reason is it, that oscThumb remembers last thumbnails type setting and right-column is after content product_info.php.
Okey, I found two way to solve. First, by adding PRODUCT_INFO_IMAGE_WIDTH and PRODUCT_INFO_IMAGE_HEIGHT for function identify of type or second, by exclusion possibility changing of type for Small Image on product_inf.php page by function identify of type.
For this, lines 40-62 of file 'catalog/includes/classes/oscthumb.php' replace with this:
  function set_type ($src, $width, $height, $thumbnail_type = 0) {
	// Try to detect what kind of image we are currently processing, so we can do what have to do with it.
	global $product_info;

	$this->thumbnail_type = $thumbnail_type;
	if ($this->thumbnail_type==0) {  // If thumbnail type is already chosen, do not try to find it again.

	  if ( $width == SMALL_IMAGE_WIDTH && $height == SMALL_IMAGE_HEIGHT) {
		$this->thumbnail_type=1;  // Small image
	  } elseif ($width == HEADING_IMAGE_WIDTH && $height == HEADING_IMAGE_HEIGHT) {
		$this->thumbnail_type=2;  // Heading image
	  } elseif ($width == SUBCATEGORY_IMAGE_WIDTH && $height == SUBCATEGORY_IMAGE_HEIGHT) {
		$this->thumbnail_type=3;  // Subcategory image
	  } elseif ($width == PRODUCT_INFO_IMAGE_WIDTH && $height == PRODUCT_INFO_IMAGE_HEIGHT) {
		$this->thumbnail_type=4;  // Product info image
	  } elseif (basename ($_SERVER['PHP_SELF'])== FILENAME_PRODUCT_INFO) {
		// Final check just to make sure that we don't interfere with other contribs.
		if (isset($product_info['products_image']) && $src == DIR_WS_IMAGES . $product_info['products_image'] && $product_info['products_id']==(int)$_GET['products_id']) {
		  $this->thumbnail_type=4;  // Product info image
		}
	  } elseif (basename ($_SERVER['PHP_SELF'])== FILENAME_POPUP_IMAGE) {
		$this->thumbnail_type=5;  // Popup image
	  }
	}
  }
and in product_info.php SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT, replace with PRODUCT_INFO_IMAGE_WIDTH, PRODUCT_INFO_IMAGE_HEIGHT, or erase it fragment.

From this time, all images which have declared PRODUCT_INFO_IMAGE_WIDTH and PRODUCT_INFO_IMAGE_HEIGHT on each page or images without declared dimension on product_info.php will be set thumbnail type for Product Info Image.

Committed any errors?
Anyone have a better solution this?

#148 osCommaniak

  • Community Member
  • 19 posts
  • Real Name:Maciej Nowak
  • Gender:Male
  • Location:Poland

Posted 12 June 2009, 20:56

View Postdodog, on Jun 8 2009, 04:04 PM, said:

Is it possible to have oscThumb with Lighbox installed and working correctly?
I think, yes!
I need some time for test it. When I done, then I publish new version of oscThumb, which well work with Lightbox. Please be patient. I have corrected some main errors yet.

#149 bobbzh

  • Community Member
  • 5 posts
  • Real Name:Bob Bzh

Posted 16 June 2009, 11:26

View PostosCommaniak, on Jun 11 2009, 06:51 PM, said:

Committed any errors?
Anyone have a better solution this?
I don't know if there is a better solution but seems perfect for me! Thank you so much! :)

And for information, I already installed lightbox and it's working well :)

#150 Amstuned

  • Community Member
  • 5 posts
  • Real Name:Mark

Posted 17 June 2009, 05:31

I installed this contribution on a new install and now the categories show up twice. I followed instructions to a T here is a example. Any idea what I did wrong? If I turn OSCThumbs off it goes back to normal. Turn it on it doubles up again.

http://upscalefashionboutique.com/index.php?cPath=26

Edited by Amstuned, 17 June 2009, 05:32.


#151 From Fan 2 Fans

  • Community Member
  • 33 posts
  • Real Name:Jean-Michel

Posted 17 June 2009, 12:31

It does not work for me.

I have installed the last version available and followed all steps scrupulously. My cache folder is on 777 accordingly to the instructions. But, When I turn this contribution on, I have the following problems:

_ images that I have placed as names of categories do not appear anymore. I simply see the name of the category
_ product images are replaced by the name of the product
_ nothing is created in te cache folder

My first idea was that it should be a problem with my cache folder BUT, when I go to a product info page, the bigger image (original size) do not appear neither.

Would you have an idea of what my problem could be?

Thx a lot!

#152 osCommaniak

  • Community Member
  • 19 posts
  • Real Name:Maciej Nowak
  • Gender:Male
  • Location:Poland

Posted 17 June 2009, 14:04

View PostAmstuned, on Jun 17 2009, 07:31 AM, said:

I installed this contribution on a new install and now the categories show up twice. I followed instructions to a T here is a example. Any idea what I did wrong? If I turn OSCThumbs off it goes back to normal. Turn it on it doubles up again.
Sorry, but I don't know if you have uploaded images to categories or you have not?

When you don't have uploaded pictures, then you in Administration -> Configuration -> Images -> Image Required -> set on: false. Otherwise, you need add images to every category.

#153 lidiapu7

  • Community Member
  • 1 posts
  • Real Name:Lidia Puccetti

Posted 24 June 2009, 23:13

Thanks!!

#154 NavCopy

  • Community Member
  • 76 posts
  • Real Name:Nav

Posted 30 June 2009, 01:36

The install went clean and all appears to work, but the Pop-Up images are now very slow since I installed this contrib. It takes less than 1 sec when oscThumb is turned off compared to 5-7 sec. when I enable it! Anyone have the same issue and/or are able to point me in a direction to speed it up?

Nav

#155 vampirehunter

  • Community Member
  • 31 posts
  • Real Name:vampire

Posted 30 June 2009, 14:42

i just installed this,
it works fine except for one thing

on one of the image i uploaded, the thumbnail has got a black bar on the right side of it added on?

is it do with size or something?

#156 lfabio2008

  • Community Member
  • 4 posts
  • Real Name:Luigi Fabio

Posted 01 July 2009, 14:47

I tried both ImageMix and oscThumb 1.1, I can't seem to get the actual option in admin to turn the features on: could someone help? I copied the files into my OSC directory, ran the database modification, but the category is not there. Help would be appreciated. Thanks!

#157 lfabio2008

  • Community Member
  • 4 posts
  • Real Name:Luigi Fabio

Posted 01 July 2009, 18:26

Reply to my own post: after N tries, with a significantly high N, it works now. Why it did not before and it does now remains a mistery.
oscThumb 1.1 + moreimages 'old' 1.4.3 + the popup_image files from the same contributor's imageMix work perfectly, after a few tries. Thanks!

#158 AndiP

  • Community Member
  • 7 posts
  • Real Name:Andi P

Posted 06 July 2009, 17:25

Hi,

first of all, nice contrib - good work!

How can i stop the creation of gif thumbs?

Thanks in advance!

#159 tpokala

  • Community Member
  • 24 posts
  • Real Name:Tomasz
  • Gender:Male

Posted 07 July 2009, 05:13

View PostFrom Fan 2 Fans, on Jun 17 2009, 01:31 PM, said:

It does not work for me.

I have installed the last version available and followed all steps scrupulously. My cache folder is on 777 accordingly to the instructions. But, When I turn this contribution on, I have the following problems:

_ images that I have placed as names of categories do not appear anymore. I simply see the name of the category
_ product images are replaced by the name of the product
_ nothing is created in te cache folder

I have the same problem :(

Any ideas?
http://shop.1-25saf.com/

#160 Mortenjan

  • Community Member
  • 56 posts
  • Real Name:Morten Jansrud

Posted 07 July 2009, 13:07

Hi,
Is it possible to fix a loading picture? instead of the product text?

Regards Morten