190 replies to this topic

[kymation]

emmetje, on Jan 10 2008, 11:40 AM, said:

Thanks for the reply!

Setting the relative path to ../ gives me the following error:

Warning: require(../includes/configure.php): failed to open stream: No such file or directory in /home/***/domains/***.nl/public_html/automatic/review_mail.php on line 23

Fatal error: require(): Failed opening required '../includes/configure.php' (include_path='.:/usr/local/lib/php') in /home/***/domains/***.nl/public_html/automatic/review_mail.php on line 23

I also tried to:
remove the first line of the script #!/usr/local/bin/php
add

chdir('/home/***/domains/***.nl/public_html/');

in the beginning of the script.
Unfortunately it didn't work out.

The path needs to be from the location of the review_mail.php file to the root of your osCommerce installation. I was assuming that was in /home/***/domains/***.nl/public_html/, which is apparently incorrect. You need to set that path correctly, or move the /automatic directory to the root of your osCommerce catalog.

Regards
Jim

[Fitty.dk]

The source code is empty. I cant see this line #!/usr/local/bin/php.

But if i write something as html it is shown as normal...

[kymation]

Fitty.dk, on Jan 11 2008, 06:30 AM, said:

The source code is empty. I cant see this line #!/usr/local/bin/php.

But if i write something as html it is shown as normal...

Your server may be treating that first line as a comment and not showing it. Since you can see HTML in the page, the script is running without errors. I suspect that you have no valid orders in your database that qualify for an email. Try running the test again, following the instructions in the Readme file.

Regards
Jim

[emmetje]

kymation, on Jan 10 2008, 08:47 PM, said:

The path needs to be from the location of the review_mail.php file to the root of your osCommerce installation. I was assuming that was in /home/***/domains/***.nl/public_html/, which is apparently incorrect. You need to set that path correctly, or move the /automatic directory to the root of your osCommerce catalog.

Regards
Jim

You're assuming correctly. The folder automatic is placed in the root dir witch is /home/***/domains/***.nl/public_html/
The errors are kind of strange because the files has bin in the right location all the time. Some other cronjob has similar problems. I managed to fix that with the chdir posted earlier.

Do you have some other options for me? Thanks for the effort

[kymation]

emmetje, on Jan 11 2008, 11:36 AM, said:

You're assuming correctly. The folder automatic is placed in the root dir witch is /home/***/domains/***.nl/public_html/
The errors are kind of strange because the files has bin in the right location all the time. Some other cronjob has similar problems. I managed to fix that with the chdir posted earlier.

Do you have some other options for me? Thanks for the effort

I was referring to the root of your osCommerce installation. I still don't know where that is, so I can't give you a path to it.

Regards
Jim

[emmetje]

kymation, on Jan 11 2008, 09:03 PM, said:

I was referring to the root of your osCommerce installation. I still don't know where that is, so I can't give you a path to it.

Regards
Jim

The root of the osCommerce installation is also /home/***/domains/***.nl/public_html/ I don't use catalog or something like that. Sorry about the confusion, I tought I made it clear in the previous post. Apperently not .

The path ../ should be correct. All files are present in the right place I've triple checked everything. When called manually the script is working fine.

[kymation]

emmetje, on Jan 13 2008, 01:46 PM, said:

The root of the osCommerce installation is also /home/***/domains/***.nl/public_html/ I don't use catalog or something like that. Sorry about the confusion, I tought I made it clear in the previous post. Apperently not .

The path ../ should be correct. All files are present in the right place I've triple checked everything. When called manually the script is working fine.

Sorry, I misunderstood. I've seen CRON do this sort of thing before, and it's a real pain. I suspect that it's some server setting somewhere, sinc I don't have the problem on any of the machines I've installed this on.

Try changing everything to absolute paths. That is, change line 17 to the full path (as you had it before.) Then change line 161 to a full path, like

$text_file = '/home/***/domains/***.nl/public_html/review_mail.tpl';

Regards
Jim

[emmetje]

kymation, on Jan 14 2008, 12:56 AM, said:

Sorry, I misunderstood. I've seen CRON do this sort of thing before, and it's a real pain. I suspect that it's some server setting somewhere, sinc I don't have the problem on any of the machines I've installed this on.

Try changing everything to absolute paths. That is, change line 17 to the full path (as you had it before.) Then change line 161 to a full path, like

$text_file = '/home/***/domains/***.nl/public_html/review_mail.tpl';

Regards
Jim

You're the best! It's working, thanks a lot!

Great contribution, even better support. Thanks again.

[shpkeeper]

Great contribution, easy to install and great instructions!! I have a small problem that I am sure is easy to answer. The email sends fine but the link in the body points to the wrong location. I need it to point to https://mystore.com/catalog/product_reviews_write.php?products_id=13877 instead of https://mystore.com/product_reviews_write.p...oducts_id=13877. It is my understanding that I need to change line 17 in review_mail.php to reflect this change, but am unsure what to change it to. Could someone please advise me what it should be changed to? My suggestions below!

$path_rel = '../../'; or $path_rel = '/../'; or $path_rel = 'catalog/../';


I just want to correct this before I send it out to customers.


Your help is greatly appreciated!!!!

[kymation]

shpkeeper, on Feb 18 2008, 02:14 PM, said:

Great contribution, easy to install and great instructions!! I have a small problem that I am sure is easy to answer. The email sends fine but the link in the body points to the wrong location. I need it to point to https://mystore.com/catalog/product_reviews_write.php?products_id=13877 instead of https://mystore.com/product_reviews_write.p...oducts_id=13877. It is my understanding that I need to change line 17 in review_mail.php to reflect this change, but am unsure what to change it to. Could someone please advise me what it should be changed to? My suggestions below!

$path_rel = '../../'; or $path_rel = '/../'; or $path_rel = 'catalog/../';
I just want to correct this before I send it out to customers.
Your help is greatly appreciated!!!!

$path_rel is set correctly if you are not getting any error messages when you run automatic/review_mail.php manually. From the information you gave, I don't believe that this is the problem.

The link to product_reviews_write.php is in the variable $link_server (see lines 57-61 of automatic/review_mail.php.) This is set by either HTTP_SERVER or HTTPS_SERVER from your catalog/includes/configure.php or catalog/includes/local/configure.php. I suspect that HTTPS_SERVER is incorrectly set. Fixing the config file settings is a pain, but you are likely to see other problems with your store if you don't get those settings right.

As a quick hack, you can just change line 131 to

			$products_string .= '  ' . $link_server . '/catalog/product_reviews_write.php?products_id=' . $products_array['products_id'] . "\n";

This is a poor long-term solution. It will not work if you change your store settings in the future, and will not work if you use this code on a store that is set up differently.

Regards
Jim

[shpkeeper]

kymation, on Feb 18 2008, 11:56 PM, said:

$path_rel is set correctly if you are not getting any error messages when you run automatic/review_mail.php manually. From the information you gave, I don't believe that this is the problem.

The link to product_reviews_write.php is in the variable $link_server (see lines 57-61 of automatic/review_mail.php.) This is set by either HTTP_SERVER or HTTPS_SERVER from your catalog/includes/configure.php or catalog/includes/local/configure.php. I suspect that HTTPS_SERVER is incorrectly set. Fixing the config file settings is a pain, but you are likely to see other problems with your store if you don't get those settings right.

As a quick hack, you can just change line 131 to

			$products_string .= '  ' . $link_server . '/catalog/product_reviews_write.php?products_id=' . $products_array['products_id'] . "\n";

This is a poor long-term solution. It will not work if you change your store settings in the future, and will not work if you use this code on a store that is set up differently.

Regards
Jim

Jim,

I really appreciate the quick response!! For the time being I will implement the quick fix. As far as a long term solution, HTTP_SERVER or HTTPS_SERVER from catalog/includes/configure.php is set as seen below. What exactly is set wrong and what shouls I change it to?

define('HTTP_SERVER', 'http://mystore.com'); // eg, http://localhost - should not be empty for productive servers

define('HTTPS_SERVER', 'https://mystore.com'); // eg, https://localhost - should not be empty for productive servers

define('ENABLE_SSL', true); // secure webserver for checkout procedure?

define('HTTP_COOKIE_DOMAIN', 'mystore.com');

define('HTTPS_COOKIE_DOMAIN', 'mystore.com');

define('HTTP_COOKIE_PATH', '/catalog/');

define('HTTPS_COOKIE_PATH', '/catalog/');

define('DIR_WS_HTTP_CATALOG', '/catalog/');

define('DIR_WS_HTTPS_CATALOG', '/catalog/');

[kymation]

shpkeeper, on Feb 18 2008, 05:04 PM, said:

Jim,

I really appreciate the quick response!! For the time being I will implement the quick fix. As far as a long term solution, HTTP_SERVER or HTTPS_SERVER from catalog/includes/configure.php is set as seen below. What exactly is set wrong and what shouls I change it to?
<code snipped>

Oops. I goofed. Your config is entirely correct; don't change it. Line 131 should be

			$products_string .= '  ' . $link_server . DIR_WS_HTTPS_CATALOG . '/product_reviews_write.php?products_id=' . $products_array['products_id'] . "\n";

Sorry about the error. I'll post an updated copy to the contribution page shortly.

Regards
Jim

[kbking]

Hi,
I'm using three different languages. How do I make it so that a customer who ordered from my Norwegian part of the shop also gets a review mail in Norwegian, etc?

[olsonsp4c]

kbking, on Feb 19 2008, 03:22 AM, said:

Hi,
I'm using three different languages. How do I make it so that a customer who ordered from my Norwegian part of the shop also gets a review mail in Norwegian, etc?

Jim,

Love the contribution. thanks for writing it! It works great...

I have one issue that I'm working to reproduce. When sending more than three emails, it sends blank emails to my customers for some reason. I'll get back with you as I'm able to reproduce it. I know it happened because on one day, all 4 customers that were sent emails responded to us asking why the email was blank.

Thanks!

Scott

[kymation]

Chris: That will not be simple. The osCommerce database does not store the customer's language. You would need to add a field (to the orders table, perhaps) to record the language_id. That could then be used to select a template in the appropriate language. I don't have time to do this right now, so feel free to experiment if you wish.

Scott: That's ... very unusual. The only thing I can think of is that the script got hung up while processing an email, but that should only happen once. Four times is just too much. Please check your error logs for any errors the script may have generated. If you can get this to repeat, you might want to add some information to the email that is sent to the store owner.

Regards
Jim

[kbking]

Thanks for answering!

I think it's some very good thinking behind this script, very useful!

I don't think I have the knowledge required to make it multi-lang capable, not yet.

This worked the first time I tried it locally. But on my remote server I got this msg:

The www.domain.se review reminder script finished execution on
19 Feb 2008 16:29:28

0 email messages were sent.

But I don't know if it was a one-timer, because the ISP had some email issues today.

[kymation]

kbking, on Feb 19 2008, 01:39 PM, said:

Thanks for answering!

I think it's some very good thinking behind this script, very useful!

I don't think I have the knowledge required to make it multi-lang capable, not yet.

This worked the first time I tried it locally. But on my remote server I got this msg:

The www.domain.se review reminder script finished execution on
19 Feb 2008 16:29:28

0 email messages were sent.

But I don't know if it was a one-timer, because the ISP had some email issues today.

It could be that there were no orders in the allotted time window. This script will only send email if the order has been shipped more than the set number of days ago and is not already marked sent. The setup will mark all old orders as sent at the time you run the setup so as to not email people who ordered a long time ago. Wait until the timeout period has passed (default is 10 days) and you should start seeing some emails go out.

The multi-language version is on the wish list. I'll work on it when I can, but don't hold your breath.

Regards
Jim

[jasyn]

this looks good. i'll give it a run tomorrow

[olsonsp4c]

kymation, on Feb 19 2008, 10:37 AM, said:

Scott: That's ... very unusual. The only thing I can think of is that the script got hung up while processing an email, but that should only happen once. Four times is just too much. Please check your error logs for any errors the script may have generated. If you can get this to repeat, you might want to add some information to the email that is sent to the store owner.

Regards
Jim

Jim,

thanks for the info. I'll check that out. I had an idea - I don't know if it is possible... to include a script where if there is more than 1 email to be sent, it delays each email by a set number of seconds. 1st email - wait 5 seconds, 2nd email - wait 5 seconds, 3rd email - wait 5 seconds, etc...

thanks for the great addon Jim.

Scott

[kymation]

olsonsp4c, on Feb 19 2008, 06:55 PM, said:

Jim,

thanks for the info. I'll check that out. I had an idea - I don't know if it is possible... to include a script where if there is more than 1 email to be sent, it delays each email by a set number of seconds. 1st email - wait 5 seconds, 2nd email - wait 5 seconds, 3rd email - wait 5 seconds, etc...

thanks for the great addon Jim.

Scott

You can use sleep() to delay a given number of seconds. I don't know if that would do any good, but you could certainly try it. Keep in mind that the entire script has to complete within a certain time (usually set to 30 seconds) or the server will kill it. If you get too many emails this could be a problem.

Regards
Jim