4 replies to this topic

[moku]

Here is my few comments and remarks about this beautiful new OsCommerce3.0a4!
It may includes things that will be fixed in beta 5 and 6, but anyway I still wrote everything I remarked.

Sorry for my poor English...

INSTALLATION

- Should list _all_ directories that have to been writeable by the server. In my cases "images/" was writable, but not all its sub-directories.

Step 1 - Database
- Add an example text for each fields. "Server: localhost or 123.123.123.123", "Username: root", etc.
- Pre-input "localhost" in the Database Server field
- Explain how to choose between Database Types (MyISAM, InnoDB, MySQLi)

Step 3 - Store Settings
- Explain where Store Owner Name will be used (in mails header, in store information pages)

Step 4 - Finished
- Is opening links in a new window really needed?

ADMINISTRATION

General
- Clicking on any row should do a default action. In my case, I think it would be really easier if clicking, a single time, anywhere on the row could edit it. (icons are small, we loose time to move mouse until them! )
- Pages should have their icon (shown in the horizontal menu) shown at the left to their name.
- HTML <title> should be defined after the page name for each pages, not a single "osCommerce Administration Tool" but a "GeoIP Modules - osCommerce Administration Tool".

Administrators > Edit
- When "Global Access" is checked, others options should be disabled, no?

Configuration: My Store
Country
- Inform (and link to) that we may also want to change "Country of Origin" (in Configuration: Shipping/Packaging)

Zone:
- It would be quicker to have two menu: one for the country and one for the zone of the selected country. (just like how it's in Zone Groups: Florida)
- Country should be automatically selectioned from current country and its zones showned.

Configuration: Customer Details
- City Minimum requirement should be of 1 or 2 by default, but not 4. There is a city in France named "Pau", and name of cities in Japanese may have a single or two characters (in kanji, for example "燕") (Source Wikipedia)

Configuration: Stock
- Instead of marking with "***" out-of-stock products, why not simply add a CSS class to product name in cart?

Credit Card Types, Payment Modules
- Explain what is the meaning of background red color. Or make it easy to understand: disable all the line (light grey). Or show status by displaying an icon (red/green) left to the name?

Languages
- Explain the date format (%Y = Year "2007", %m = Month "12", %d = Day "31", etc.)
- Accept the space as a valid Thousands Separator (French language: "12 345,67"). But replace a single " " by the HTML code " "
- This new language system is great. But we cannot anymore include some PHP code in our languages definitions... Is there no way? For example I used it to display cheers for Christmas.

Languages: English
- Should provide a search field to find strings without having to open all definition groups.

Countries
- Add a search field to find entries without having to display each pages one after another.
- Explain the Address Format (somes entries have a empty field)

Categories
- Adding a shortcut "add a new product to this category" could be helpful.
- Category image is resized by HTML, not by the new thumbnail system.
- "maximum_file_upload_size" is not defined. (already noticed in the second post of this thread, ok)
- Just like we have for products, it would be great to define a keyword for categories which would be used in the URL instead of cPath. (again, this keyword should be automatically defined after the category/product's name until user change it eventually)
- [BUG]: Moving a category to itself failed with:

Quote

Notice: Use of undefined constant ERROR_CANNOT_MOVE_CATEGORY_TO_PARENT - assumed 'ERROR_CANNOT_MOVE_CATEGORY_TO_PARENT' in /home/www/tests/oscommerce-3.0a4/admin/includes/content/categories.php on line 185

Warning: Cannot modify header information - headers already sent by (output started at /home/www/tests/oscommerce-3.0a4/admin/includes/content/categories.php:185) in /home/www/tests/oscommerce-3.0a4/admin/includes/functions/general.php on line 46

Products
- If there is only one language, maybe it's not needed to display languages flags and various code (toggleDivBlocks() & toggleClass() in previous mode)
- When duplicate a products, it should by default select the current main category and propose to duplicate (instead of link) the product. (We can already link products directly inside the products edit page)
- We would like to be able to batchEdit, at least status, names, prices and basic data.

Products > Edit mode:
- explain what are the meanings of not obvious fields like "Keyword", "Tags", "URL". Also explain how/where they will be used. This could be done by adding a "?" icon near the field label.
- [BUG]: Calendar (for Date Available:) is shown below the div (class="tab-page") which have a "z-index: 2" when the calendar don't have it defined.
- [BUG]: images are not showing at all ("[icon_progress_ani] Loading images from server.." is displayed instead). Because of this, I can't add/change image to new products. (But catalog side does display the sample product's image (Pro PHP Security) without problem)
- [BUG]: if when saving there is an error ("This product keyword is already in use"), the updated product description is lost and reset to the previous one!
- [BUG]: A product can have an empty name!
- Product Key should be automatically defined (from the title or the model?) if user don't specify it or until he specify it.
- (Pressing "Enter" when focus is in a field does not validate the editing. Must click on Save button.)

Customers new management is great!
- [BUG]: In address book, icon's title text is not defined "icon_telephone" (for phone) and "icon_print" (for fax!)
- In the same way we can insert a customer by ourself, it should be also possible to insert an order for him.
- Having a way to know how many orders (and a link to them) a customers done would be great.

Image Groups
- Should have an option for watermarking somes images sizes

Services
- Reviews: explain what is the "Review Level" and their codes 0, 1 and 2. Same for codes for "Moderate Reviews".
- Session: Explain why we would like to Check SSL Session ID, User Agent and other things. Same for Regenerate Session ID.
- [BUG]: Category Path: even if we disable Number Of Products In Each Category, there is still a "(0)" displayed after the category name!

Orders
- We should be able to edit every parts of an order (add/remove/edit products, address, payment method, prices, etc.)

Templates
- [BUG]: When I tried to make the Table Based Template the default one, it replied this (but made it the default template anyway)

Quote

Notice: Undefined index: configuration in /home/www/tests/oscommerce-3.0a4/admin/includes/content/templates.php on line 45

Warning: Cannot modify header information - headers already sent by (output started at /home/www/tests/oscommerce-3.0a4/admin/includes/content/templates.php:45) in /home/www/tests/oscommerce-3.0a4/admin/includes/functions/general.php on line 46

- [BUG]: Anyway, it seems table based template is not finalized, as the catalog site is quite broken! All the page is full of:

Quote

Warning: include(templates/table_based/modules/boxes/categories.php) [function.include]: failed to open stream: No such file or directory in /home/www/tests/oscommerce-3.0a4/templates/table_based.php on line 108

Templates Modules: Boxes
- [BUG]: After installing "Ordering Steps", all boxes names strings becames "box_best_sellers_heading" or "box_order_history_heading", both admin and catalog sides (all languages strings in boxes are not find, others -- not in boxes -- are ok). In the admin, only "Ordering Steps" and "Templates" are still translated in the list of boxes. If I install this two modules, their names become "box_tell_a_friend_heading" and "box_ordering_steps_heading". The page "Template Modules Layout: Boxes" does not have this problem. (going to index.php?languages=1 and updating "modules-boxes" and "modules-content" restored languages definitions)

Template Modules Layout: Boxes
- [BUG]: Page Specific icon's title is not defined: displays "icon_checkbox". (same on "Template Modules Layout: Content")

Administrators Log
- Sometimes it does not provides enought information on what has been changed: "osc_configuration.configuration_value 2 1" don't help me so much. (but most are well defined)
- All of this fields should provide a way to directly go to the page where we could change back the value.
- Maybe its not consistent with the rest of the admin interface to have both the "i" icon and the module name (with a folder icon in front) linking to the same page.

Database Backup Manager
- If available it could also provide the TAR, TAR.GZ and TAR.BZ2 compression.

Banner Manager
- I wonder if there is a real need for a banner system, when great offer like http://www.openads.org/ exists. It would be more efficient to include this system.
- Anyway, one point that could be usefull is that the banner could be displayed after the current language of the customer. Display the English version banner for en_US and the French one for fr_FR, but still it's the same banner, only image change.

File Manager
- Just like it does for "Upload" and "New Directory", deny to create "New File" when directory is not writable.

Newsletter Manager
- Again, it should at least have a language separation feature (maybe in beta5 or 6?)
- I have one customer subscribing to newsletter, but it still shows "Recipients receiving this newsletter: 0" when I want to send the newsletter (products notifications) and I have only choice of "Back" or "Cancel" buttons. Isn't this used to notify customers of a choice of new products? (it worked when I changed module to "newsletter" instead of "product notifications"). Price or availability update notification should be done automatically once a day (per exemple).

Who's Online
- [BUG]: Display this before the visitors table:

Quote

Notice: Uninitialized string offset: 0 in /home/www/tests/oscommerce-3.0a4/admin/includes/functions/general.php on line 280

Notice: Uninitialized string offset: 0 in /home/www/tests/oscommerce-3.0a4/admin/includes/functions/general.php on line 282

Notice: unserialize() [function.unserialize]: Argument is not a string in /home/www/tests/oscommerce-3.0a4/admin/templates/pages/whos_online/main.php on line 94

Warning: end() [function.end]: Passed variable is not an array or object in /home/www/tests/oscommerce-3.0a4/admin/templates/pages/whos_online/main.php on line 95

Notice: unserialize() [function.unserialize]: Argument is not a string in /home/www/tests/oscommerce-3.0a4/admin/templates/pages/whos_online/main.php on line 97

Notice: Uninitialized string offset: 0 in /home/www/tests/oscommerce-3.0a4/admin/includes/functions/general.php on line 280

Notice: Uninitialized string offset: 0 in /home/www/tests/oscommerce-3.0a4/admin/includes/functions/general.php on line 282

Notice: unserialize() [function.unserialize]: Argument is not a string in /home/www/tests/oscommerce-3.0a4/admin/templates/pages/whos_online/main.php on line 99

Maybe because my IP is 127.0.0.1?

Statistics
- Again, isn't it wrong with the admin interface logics in others pages to have both module name and action's icon who goes to the same page?
- It would be very useful if there is also an automatic mail notification for low stock products.

CATALOG

CSS:
- CSS classes should have a meaningful name (ex. not "smallText" but "products_model" for the products model on products page)

Create an Account
- Should confirm account creation by sending a link by mail: many customers don't know their own mail, make mistake when they input it or simply just want to play with your shop and write a false email (like "aaaa@aaa.com"). We don't want to count thoses accounts as potential customers.
- if "Gender" is optional, it should have a third option givint the customer an option to pass the question (if he clicked on Male or Female then he couldn't cancel this whithout reloading the whole page)
- State should be displayed as soon as Country field is changed (with some javascript magic)

Account
- Should display the "My Orders" box only if the customer have actually made one or more orders.

Shopping Cart
- [BUG]: In the product listing: "Pro PHP Security (Top Category)". But why "Top Category" is diplayed? (this product is in "Books > PHP" category)

Checkout
- There should be a "chronological ruler" when ordering, showing current step among total steps ("Step 2 of 5"). OsC2.2 had this -- but it was hard to see (too low in page layout) and not so well designed (choice of colors and images)
- "Your Recent History" should not be shown while customer is ordering! This moment is crucial, so we must not give him any way to stop in the middle of the order.
- Should include order number in the subject of all mails related to orders, from the first confirmation mail (not "Order Process" but "Shop Name: Your Order #34 in process") but also for any mail sent from the admin related to this order (not "Order Update" but "Shop Name: Update to Your Order #34").
- [BUG]: If there is no products model then there should not have " ()" right to the product name in the confirmation mail (cf. includes/classes/order.php line 374)
- [BUG]: For a new order, the Status History (both in admin and catalog) show two status made at the same time:

Quote

04/04/2007 11:58:55 4/4 Shipped This is a note to this order
04/04/2007 11:58:55 1/4 Pending

The default status is "1/4 Pending" (osID:1), ok, but why "4/4 Shipped" (osID:4) also appears??
This two status are done on any new order, even if the customer did not write a comment.

- [BUG]: Mail sent about an order from admin is bad formatted (end-of-line "\r\n" seems to be dropped):

Quote

Site Name------------------------------------------------------Order Number: 3Detailed Invoice: http://localhost/tests/oscommerce-3.0a4/ac...?order_id=3Date Ordered: Wednesday 04 April, 2007

Order Comment------------------------------------------------------Send your payment to this address please:
Address For Payment

Thank you.

Site Owner.

Order Status------------------------------------------------------New Status: 2/4 Waiting payment

Please reply to this e-mail if you have any questions regarding this order.

Reviews
- [BUG]: When writing a review the constant ENTRY_NAME is not defined (products.php?reviews=new)

Quote

Notice: Use of undefined constant ENTRY_NAME - assumed 'ENTRY_NAME' in /home/www/tests/oscommerce-3.0a4/templates/default/content/products/reviews_new.php on line 40

Cookies
- When trying to access checkout.php/shipping I'm redirected to info.php/cookie
- Should also provide information on how to enable cookies for Firefox and Opera, at least, no?
(remark that this message is displayed to me althought I have cookies enabled without any restriction. I also had this problem with OsC2.2... I have to disable "Force Cookie Usage" for being able to create an account, checkout, etc.)

Debug
- Is it normal that there are two SQL queries not included in the "Number of queries" counter?

Quote

[...]
[#32 - 0.00023s] [...]
Number of queries: 32 [0s]
[#33 - 0.00498s] select count(*) as total from osc_sessions where sesskey = [...]
[#34 - 0.00033s] update osc_sessions set expiry = '1175650160', value = [...]
Execution Time: 0.121s [osC_Services_debug]

Questions

- Where is the "Display Cart After Adding Product" option? (it was in "My Store" in OsC2.2)
- Will it be easily possible, and via admin interface, to make as much info.php's pages as we want? (just like "info.php?contact" and so on)


Sorry for this long post, but I hope it will help!

Anyway, I didn't said it earlier, but as far as my coding level let me see, that's a wonderful work! Gokurosama!

[Frank Heinen]

Nice report moku!! Thanks for your testing.

Could you please add the bugs and improvements to our development server?

[Bushmaster]

Half of his bugs are fixed by deleting the cache files. And a good portion of the rest will probaly be answered when the documentation is done.

[enigma1]

Is it possible to get a pre-installed version of ms3? When I install it locally goes upto the first page testing the database and stops there. There are no errors reported or anything.

Tried the a4 with php5.x, mysql5.x, ie6.

I can set it up manually but the install process does all sorts of alterations to the dbase so I am not sure.

Edited by enigma1, 06 April 2007, 19:40.

[dpower717]

What i noticed is that you are able to create a new customer and also can type his password.
I think this should be auto-generated. Just to give youre customers that safe feeling that you are nt creating his password.

rdgds