384 replies to this topic

[clarocque]

falsedawn, on Feb 7 2005, 12:05 AM, said:

Shouldn't really include the /cache/ directory as part of the install - best to update the install instructions and tell the user exactly where they need to specify the cache directory. Several other contribs use a cache directory, and best to let them point to the one they are using for others...

Also, the reset_meta_cache.php file is currently redundant, as you haven't included the SQL script to make this controllable from the Admin side.

Also, including configuration values in
catalogincludeslanguagesenglishmeta_tags.php is not a good idea - these should be in the configuration file.

Apart from these minor oversights - it looks good - I will see how it performs...

<{POST_SNAPBACK}>

I agree with some of what you are saying, however in effort to avoid configuration issues (which seems to be tuff for many people) I provided the file. Like many contributions, it may require some changes if other things are installed.

This was a custom job I did and simply ported to here and added the variables for a quick setup...

Feel freee to expand - that is why it is open source

Chris

[spleen]

hi there!

im using the STS system and just tried to install your contribution.
well no errors but no effect at all.

guess its because of the STS template system.

you agree? or any hints howto solve this problem (as i prefer your idea of metatags over the meta tag controller)

greez

spleen

[spleen]

another little thingy...

well in the installation it says

Quote

STEP 3 - ...
Directly AFTER add this:

but i had to REPLACE the original <title> tag to get it working.



and the "default" values for index/all in meta_tags.php do not work properly.
if i add an additional desc it adds it twice. for index.php its not working at all.

and on product listing i got an additional " - " as prefix at desc.

maybe i did something wrong... but doesnt seems so.

anyways great contrib!

p.s. - deinstalled STS - was crap anyways (for caching etc)

[clarocque]

spleen, on Feb 9 2005, 12:15 PM, said:

another little thingy...

well in the installation it says
but i had to REPLACE the original <title> tag to get it working.
and the "default" values for index/all in meta_tags.php do not work properly.
if i add an additional desc it adds it twice. for index.php its not working at all.

and on product listing i got an additional " - " as prefix at desc.

maybe i did something wrong... but doesnt seems so.

anyways great contrib!

p.s. - deinstalled STS - was crap anyways (for caching etc)

<{POST_SNAPBACK}>

I have fixed the bugs you mentioned except I was unable to duplicate the xtra - ????

Do you have a URL?

And I am sorry you are right the install should hve been replace....

I will upload the fixes in a few minutes... you can try that -

[clarocque]

OK uploaded the fixes...


FYI, INDEX tags should only show on the default index page, if you want them on all index pages let me know.

Sorry I cant comment on STS I have never used it, but this works fine with BTS (easier install actually)

[spleen]

its a clean OSC install - i switch to product listing (DVD category)

got this as desc:

<META NAME="Description" Content="- DVD Filme from osCommerce">

there is the trailing "-"

even if i enter some stuff for the HEAD_DESC_TAG_INDEX i got "- test" as desc.
(thanks that those variables are working now!)

the double thing is fixed aswell - thanks!


ah and nevermind about the STS... i dont use it anymore - but i didnt replace the title on first installation. so maybe its working aswell - but maybe there are probelms with head tas controller code inside the STS (its merged in latest version)

Edited by spleen, 09 February 2005, 19:17.

[clarocque]

spleen, on Feb 9 2005, 03:15 PM, said:

its a clean OSC install - i switch to product listing (DVD category)

got this as desc:

<META NAME="Description" Content="- DVD Filme from osCommerce">

there is the trailing "-"

even if i enter some stuff for the HEAD_DESC_TAG_INDEX i got "- test" as desc.
(thanks that those variables are working now!)

the double thing is fixed aswell - thanks!
ah and nevermind about the STS...  i dont use it anymore - but i didnt replace the title on first installation. so maybe its working aswell - but maybe there are probelms with head tas controller code inside the STS (its merged in latest version)

<{POST_SNAPBACK}>

OK I see where you mean now...
Open /includes/meta_tags.php got to line 205
find:

// Description
$metadescription=$desc;
if (tep_not_null($index_desc) && $default==false )
$metadescription.=' - '. $index_desc;
$metadescription=meta_create_meta_description($metadescription);

and replace with:

// Description
$metadescription=$desc;
if (tep_not_null($metadescription)&& $default==false )
$metadescription.=' - ';
if (tep_not_null($index_desc) && $default==false )
$metadescription.=$index_desc;
$metadescription=meta_create_meta_description($metadescription);

Try that I dont have time to test right now so let me know...

Chris

[spleen]

hi there!

well index.php is fine now!

but DVD category:

<META NAME="Description" Content="- DVD Filme from osCommerce -">

there is still the trailign slash and now another ending one...

[clarocque]

spleen, on Feb 10 2005, 08:02 AM, said:

hi there!

well index.php is fine now!

but DVD category:

<META NAME="Description" Content="- DVD Filme from osCommerce -">

there is still the trailign slash and now another ending one...

<{POST_SNAPBACK}>

Sorry, I can't duplicate that... but just to let you know, by defaulyt I added dashes in a few places. If you want to csutomize yours go through the code and commend the lines.

Like line 208 , change that to //$metadescription.=' - ';

These are not bugs just a tatst difference java script:emoticon('')
smilie

Hope that helps...

Chris

[spleen]

hehe yeah i understand

seemed for me like beeing a small bug that the seperator will be added even if there is no second attribute.

well ill give it a try when im back from holidays

[clarocque]

[quote name='spleen' date='Feb 10 2005, 06:26 PM']hehe yeah i understand

seemed for me like beeing a small bug that the seperator will be added even if there is no second attribute.

well ill give it a try when im back from holidays
[right]<{POST_SNAPBACK}>[/right][/quote]

Yes, I would agree - however I am not able to duplicate that when there is no second one - sorry...

I see this....
[quote]<META NAME="Description" Content="DVD Movies - Action from osCommerce - Desc to add to all - Desc for index...">[/quote]

and

[quote]<META NAME="Description" Content="DVD Movies from osCommerce - Desc to add to all - Desc for index...">[/quote]

and

[quote]<META NAME="Description" Content="Courage Under Fire (DVD-CUFI) by Fox - Regional Code 2 (Japan, Europe, Middle East, South Africa). Languages English, Deutsch. Subtitles English, Deutsch, Spanish. Audio Dolby Surround 5.1. Picture Format 169 Wide-Screen....">[/quote]

sorry...

Chris

[TCwho]

Quote

your cookies should not have http ior https or www ...

why do you say this?

[clarocque]

TCwho, on Feb 10 2005, 09:03 PM, said:

why do you say this?

<{POST_SNAPBACK}>

If you use a . you will avaid issues when the url changes...

 define('HTTP_COOKIE_DOMAIN', '.domain.com');
  define('HTTPS_COOKIE_DOMAIN', '.domain.com');

this will also keep the cookie valid switching from NONSSL<->SSL

[Chemo]

TCwho, on Feb 10 2005, 08:03 PM, said:

why do you say this?

<{POST_SNAPBACK}>

...because Chris is correct in advising that the cookie SCOPE should be defined as such.

That is the #1 most common mistakes I have seen with store owner configuration. As Chris as stated it should be .domain.com and NOT www.domain.com or http://www.domain.com as is so common.

.domain.com - corrent
www.domain.com - will work but may present problems
http://www.domain.com - don't even try it...will fail every time

Bobby

[TCwho]

wow thanks. Mistake I had made myself, although in my situation I had not encountered any problems, although I am not live yet, and am not forcing cookies...

when I was getting my ssl cert, I had the choice of getting domain.com or www.domain.com ... I got it issued to www.domain.com, but would it have been better to get it issued to .domain.com?

thanks guys, I appreciate this help

[clarocque]

TCwho, on Feb 10 2005, 10:50 PM, said:

wow thanks.  Mistake I had made myself, although in my situation I had not encountered any problems, although I am not live yet, and am not forcing cookies...

when I was getting my ssl cert, I had the choice of getting domain.com or www.domain.com ... I got it issued to www.domain.com, but would it have been better to get it issued to .domain.com?

thanks guys, I appreciate this help

<{POST_SNAPBACK}>

No, you were correct to get it as www.domain.com. If you got your SSL at domain.com, when it is called you would get a SSL error.
(Assuming you are using a domain with the www. like www.domain.com).

[TCwho]

Thanks Chris

[kslager]

Does anyone know if cDynamic Meta Tags compatible with the Simple Template System (STS)? I cant seem to get them to work together.

Tried putting $headcontent into the header of my template file AND in the php source..

[clarocque]

kslager, on Feb 11 2005, 04:49 AM, said:

Does anyone know if cDynamic Meta Tags compatible with the Simple Template System (STS)?  I cant seem to get them to work together. 

Tried putting $headcontent into the header of my template file AND in the php source..

<{POST_SNAPBACK}>

I am not sure as I have never looked at STS, it does work with BTS - if I get a chane I will take a look at STS and see what is different.

With out looking at it I believe the only difference for BTS is step 3, instead of having to do all pages you only have to do one tpl page.

I will try to look at STS soon.

Chris

[gorilla]

clarocque, on Feb 11 2005, 03:30 AM, said:

No, you were correct to get it as www.domain.com.  If you got your SSL at domain.com, when it is called you would get a SSL error.
(Assuming you are using a domain with the www. like www.domain.com).

<{POST_SNAPBACK}>

Hi , sorry to sidetrack the topic but

i got mine as https://domain.com and seem to be having issues with oscommerce as i get redirected to https://www.domain.com , how could i fix this so it'll point me to https://domain.com ?