Phocea

Hello, Has anyone got a test site where I could have a look at the filtering and comparaison functionality please? If I understand correctly, the only negative point of the filter is that you can add some but cannot remove them? Thanks, Greg

Hello, Regarding the canonical url, i made some changes to the code I submitted to you a while back. It is basically enough to add: $canonical_url = tep_href_link(basename($_SERVER['PHP_SELF']), tep_get_all_get_params()); just before if (tep_not_null($canonical_url)) echo ' <link rel="canonical" href="'. $canonical_url.'">'. "\n"; All other initialisation of the variblae are unnecessary. Also you may want to remove the closing / on each of the META links, since this is not W3C compliant.

Can you explain what is the difference of functionality between what you are proposing and the standard get_browser_language() method used in the Oscommerce language class ?? By default, Oscommerce already automatically detect browser language and set the catalogue navigation language accordingly (or revert to the default one).

I dont exactly agree since we can end up with 3 kinds of URL for the same page and have a bad case of duplicate content www.domain.com/category_name_in_english/product_name_in_english.html www.domain.com/category_name_in_english/product_name_in_english.html?language=uk www.domain.com/category_name_in_english/product_name_in_english.html?language=fr (by clicking on the flag) If we take a concrete example on your dev site we can have: http://www.fwrdev.co.uk/cmonitor/index.php/drama-c-3_15 http://www.fwrdev.co.uk/cmonitor/index.php...=en&sort=2a http://www.fwrdev.co.uk/cmonitor/index.php...=de&sort=2a It seems that at product level you do a redirection to correct the product name when choosing another URL, however the url is still wrong on the actual flag link

Just a short message with questions and ideas for features in this new module. I had a quick look at the code and the architecture has nothing to do with the old series 2. Must have been some work to refactor all of this, Well done !! * The demo version seems to be in the non rewrite mode you described since we can still see the php name of the page you are on. Is this for debugging purposes. Is there a way to change it on the demo site ourselves or should I installl it on one of my own? * In the version 2, there was an option to display the parent category in the path. Furthermore, i changed the code to show the main parent categorie/the current category/the product name (http://domain.com/category1/category1_3/product_name). Is it possible to have this as an option straight out? In the function I changed I also gave the option to choose the delimiter between each category, so one can use - or / to display like a directory structure (at the time it was still discussed which one was actually better, I opted for / :blush: ) * Will this version finally handle the language parameter correctly. Commercial products like magi SEO are doing a great job of it. This would avoid "duplicate content" on pages existing with or without the language parameter. I guess that default languages should show in the normal domain name, and other in a virtual sub directory. Something like the code below shoudl take care of the rewriting RewriteCond %{QUERY_STRING} ^language=fr$ RewriteRule ^(.*)$ http://www.eboutik.net/fr/$1? [L,R=301] RewriteCond %{QUERY_STRING} ^language=en$ RewriteRule ^(.*)$ http://www.eboutik.net/en/$1? [L,R=301] or simply RewriteRule ^([a-z]{2})/(.*)$ $2?language=$1&%{QUERY_STRING} Not sure where this should then be handled in the abstract SEO class ( substr($_SESSION['language'], 0, 2).'/'; ??) * The above logic could also apply to currencies maybe ? RewriteRule ^(ch)/(.*)$ $2?language=fr&currency=CHF&%{QUERY_STRING} RewriteRule ^(fr)/(.*)$ $2?language=fr&currency=EUR&%{QUERY_STRING} RewriteRule ^(uk)/(.*)$ $2?language=en&currency=GBP&%{QUERY_STRING} RewriteRule ^(us)/(.*)$ $2?language=en&currency=USD&%{QUERY_STRING} RewriteRule ^(ca)/(.*)$ $2?language=en&currency=CAD&%{QUERY_STRING} RewriteRule ^(ca-fr)/(.*)$ $2?language=fr&currency=CAD&%{QUERY_STRING} * Another hack I made on my shop is for the split per page in the product listing. I however done this directly into the split_page_results.php class. I seem to remember spotting a SEO 2 soltuion on those forums * Similar to the above, what about the filters on the product listing? I think there is enough to discuss for now :) Dont ger me wrong, this is not a list of features I am asking you to do .. just want to have an opinion on the feasibility in the new code structure, and if some are already planned.

No problem ..watch out for the attached oe which doenst seems to display properly on this forum... Also I guess that currency signs could be converted as standard in each languages file

Great job on taking into your hand to update chemo great contribution. I am yet to try it our but will do this as soon as I can. I have throught the few years of use of the 2 series, made a few changes to include rewriting of some other pages, I will get back to you with those to see if they can be included here as standard. By the way, are languages handled in series 5 (I mean to we have a rewrite like www.domain.com/uk, /fr, /de/ etc...). i know I have seen talk about this in a few places, so i was wondering :) To finish just a small contribution for the french character conversion here is the one I would use: // French $char_convert = array('à' => 'a', 'â' => 'a', 'æ' => 'ae', 'ç' => 'c', 'é' => 'e', 'è' => 'e', 'ê' => 'e', 'ë' => 'e', 'î' => 'i', 'ï' => 'i', 'œ' => 'oe', 'ô' => 'o', 'ù' => 'u', 'û' => 'u', 'À' => 'A', 'Â' => 'A', 'Æ' => 'AE', Ç' => 'C', 'È' => 'E', 'É' => 'E', 'Ê' => 'E', 'Ë' => 'E', 'Î' => 'I', 'Ï' => 'I', 'Œ' => 'OE', 'Ô' => 'O', 'Ù' => 'U', 'Û' => 'U', '€' => 'Euros');

Hello, I would like to propose the following changes to introduce canonical url link into header_tags, to help reduce the duplicate_content problems. Changes need to take place in includes/header_tags.php as follow: After case (strstr($_SERVER['PHP_SELF'],FILENAME_DEFAULT) or strstr($PHP_SELF,FILENAME_DEFAULT)): Add // Canonical URL add-on $canonical_url = tep_href_link(FILENAME_DEFAULT, 'cPath='.$current_category_id); After default: $filename = FILENAME_PRODUCT_INFO; } Add // Canonical URL add-on if ($_GET['products_id'] != '') { $canonical_url = tep_href_link($filename, 'products_id='.$_GET['products_id']); } After case (strstr($_SERVER['PHP_SELF'],FILENAME_SPECIALS) or strstr($PHP_SELF,FILENAME_SPECIALS)): Add // Canonical URL add-on $canonical_url = tep_href_link(FILENAME_SPECIALS); After $header_tags_array['keywords'] = tep_db_prepare_input($defaultTags['default_keywords']); Add $canonical_url = tep_href_link($PHP_SELF); Before echo '<!-- EOF: Header Tags SEO Generated Meta Tags -->' . "\n"; Add if ($canonical_url !='') echo ' <link rel="canonical" href="'.$canonical_url.'" />'. "\n"; Obviously similar changes will need to be done for any special pages you may have using parameters. Since i do not know if Jack_mcs has another version in the work I prefer to post this add-on here for the time being, for open discussion.

Tried this. Add missing pages was still not doing anything with no files in the root. I then added product_info.php then account.php and got a similar error: Fatal error: Maximum execution time of 10 seconds exceeded in /home/www/25cfe5b63d9a42bb468f3a2c805e00f0/web/demoshop/admin/header_tags_seo.php on line 274 :(

Hello, I have now added your contribution to a couple of shops and I am hitting a recurring problem in the administration side. Basically, when choosing the Add New Page functionality, nothing happens. Also if I then try to choose Select a File again in the drop down, I get the following error: Fatal error: Maximum execution time of 10 seconds exceeded in /home/www/25cfe5b63d9a42bb468f3a2c805e00f0/web/development/w3c/admin/header_tags_seo.php on line 276 I have tried this on 3 different servers, each with their own settings but always get the problem. A friend of mine also get this problem on is local server (it was him who pointed me out the issue to start with). Any ideas?

The onChange "bug " is a well known problem between browsers. The official workaround is to use onpropertychange which is cross browsers compatible.

Good idea lildog. I am actually putting the link into the notes area at the moment ;)