Jump to content



Issue Information

  • #000134

  • 0 - None Assigned

  • New

  • 2.3

  • -

Issue Confirmations

  • Yes (1)No (0)
Photo

Possible DatePicker issue with IE8

Posted by Hotclutch on 14 November 2010 - 04:36 PM

create_account.php and advanced_search.php fail to load with a javascript error. When turning DOB to false in Admin under customer details, the page loads.

PC OS = XP, IE8

I've just tested this with IE8 but with Windows 7 and I am unable to reproduce this, is this a vanilla 2.3 or did you make changes?

Mark Evans, on 14 November 2010 - 08:14 PM, said:

I've just tested this with IE8 but with Windows 7 and I am unable to reproduce this, is this a vanilla 2.3 or did you make changes?

I get it with vanilla as well.

Confirmed error from another XP PC, also IE8.

I'm just downloading a copy of XP from MSDN and will give this a try.


How are you running your site, is it locally with WAMP or with a hosting provider?

Mark Evans, on 14 November 2010 - 11:59 PM, said:

I'm just downloading a copy of XP from MSDN and will give this a try.
How are you running your site, is it locally with WAMP or with a hosting provider?

In a folder on my live site.

Hi Mark,

I'm also having thesame prob. I just installed osC 2.3.1 to run my site.
If i also change Date of Birth to False, the create_account page will be ok not the advance_search page.

My site is running with a hosting provider.

I'm using Windows 7 with IE8

Will be glad to get a solution.

Cheers

Edited by olabisi, 16 November 2010 - 08:28 PM.


This appears to be a problem with IE8. My site loads fine in Google Chrome.

HOST = AUSSIEHOST
OS = WIN7
BROWSERS = IE8, Chrome V8, Mozilla V3
SHOP VERSION = 2.3.1 -->VANILLA

I have not been able to replicate the error

maybe a fix for MSIE :
resolve this issue by adding defer=”defer” to your script tags.
eg :
<script type="text/javascript" defer=”defer” src="ext/jquery/ui/i18n/jquery.ui.datepicker-<?php echo JQUERY_DATEPICKER_I18N_CODE; ?>.js"></script>
?

I'm able to reproduce this bug on virtual XP with IE 8
error message :

Quote

Webpage error detailsUser Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0)
Timestamp: Wed, 8 Dec 2010 12:42:54 UTC
Message: HTML Parsing Error: Unable to modify the parent container element before the child element is closed (KB927917)
Line: 0
Char: 0
Code: 0
URI: https://domain.com/catalog/create_account.p...1r9iq3uqb56jv14


solutions :
file create_account.php :
replace line 310
<td class="fieldValue"><?php echo tep_draw_input_field('dob', '', 'id="dob"') . '&nbsp;' . (tep_not_null(ENTRY_DATE_OF_BIRTH_TEXT) ? '<span class="inputRequirement">' . ENTRY_DATE_OF_BIRTH_TEXT . '</span>': ''); ?><script type="text/javascript">$('#dob').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-100:+0'});</script></td>
with :
<td class="fieldValue"><?php echo tep_draw_input_field('dob', '', 'id="dob"') . '&nbsp;' . (tep_not_null(ENTRY_DATE_OF_BIRTH_TEXT) ? '<span class="inputRequirement">' . ENTRY_DATE_OF_BIRTH_TEXT . '</span>': ''); ?><script type="text/javascript">jQuery(document).ready(function () {$('#dob').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-100:+0'});})</script></td>


file advanced_serach.php :
replace lines 139 to 148 :
<script type="text/javascript">
$('#helpSearch').dialog({
  autoOpen: false,
  buttons: {
	Ok: function() {
	  $(this).dialog('close');
	}
  }
});
</script>



with :
<script type="text/javascript">
jQuery(document).ready(function () {$('#helpSearch').dialog({
  autoOpen: false,
  buttons: {
	Ok: function() {
	  $(this).dialog('close');
	}
  }
});});
</script>

replace line 175 :
<td class="fieldValue"><?php echo tep_draw_input_field('dfrom', '', 'id="dfrom"'); ?><script type="text/javascript">$('#dfrom').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-10:+0'});</script></td>

with :
		<td class="fieldValue"><?php echo tep_draw_input_field('dfrom', '', 'id="dfrom"'); ?><script type="text/javascript">jQuery(document).ready(function () {$('#dfrom').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-10:+0'});});</script></td>

line 179 :
<td class="fieldValue"><?php echo tep_draw_input_field('dto', '', 'id="dto"'); ?><script type="text/javascript">$('#dto').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-10:+0'});</script></td>
with :
		<td class="fieldValue"><?php echo tep_draw_input_field('dto', '', 'id="dto"'); ?><script type="text/javascript">jQuery(document).ready(function () {$('#dto').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-10:+0'});});</script></td>


file admin/categories.php
change lines 635 to 649 :
$('#piDelConfirm').dialog({
  autoOpen: false,
  resizable: false,
  draggable: false,
  modal: true,
  buttons: {
	'<?php echo DELETE; ?>': function() {
	  $('#piId' + piDelConfirmId).effect('blind').remove();
	  $(this).dialog('close');
	},
	'<?php echo CANCEL; ?>': function() {
	  $(this).dialog('close');
	}
  }
});
with :
jQuery(document).ready(function () {$('#piDelConfirm').dialog({
  autoOpen: false,
  resizable: false,
  draggable: false,
  modal: true,
  buttons: {
	'<?php echo DELETE; ?>': function() {
	  $('#piId' + piDelConfirmId).effect('blind').remove();
	  $(this).dialog('close');
	},
	'<?php echo CANCEL; ?>': function() {
	  $(this).dialog('close');
	}
  }
});
});
change lines 691 to 693 :
$('#products_date_available').datepicker({
  dateFormat: 'yy-mm-dd'
});
with :
jQuery(document).ready(function () {$('#products_date_available').datepicker({
  dateFormat: 'yy-mm-dd'
});});

file admin/specials.php :
change lines 128 to 130 :
$('#expdate').datepicker({
  dateFormat: 'yy-mm-dd'
});
with :
jQuery(document).ready(function () {$('#expdate').datepicker({
  dateFormat: 'yy-mm-dd'
});
});

file admin/customers.php :
change line 423 :
			  <script type="text/javascript">$('#customers_dob').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-100:+0'});</script>
with :
			  <script type="text/javascript">jQuery(document).ready(function () {$('#customers_dob').datepicker({dateFormat: '<?php echo JQUERY_DATEPICKER_FORMAT; ?>', changeMonth: true, changeYear: true, yearRange: '-100:+0'});});</script>

file admin/banner_manager.php :
change lines 289 to 296 :
<script type="text/javascript">
$('#date_scheduled').datepicker({
  dateFormat: 'yy-mm-dd'
});
$('#expires_date').datepicker({
  dateFormat: 'yy-mm-dd'
});
</script>
with :
<script type="text/javascript">
jQuery(document).ready(function () {
$('#date_scheduled').datepicker({
  dateFormat: 'yy-mm-dd'
});
});
jQuery(document).ready(function () {
$('#expires_date').datepicker({
  dateFormat: 'yy-mm-dd'
});
});
</script>


foxp2, on 08 December 2010 - 07:40 PM, said:

...

Thanks for these fixes, I can confirm they work for me on IE8.

I have a 2.3.1 default install which is showing slow loads and small freezes on IE8. IE9 and everything else is fine. I have been advised that IE8 has a poor javascript engine.

Is this a bug that can be fixed with all the above changes? This issue certainly doesnt appear isolated and I have done a few installs which all show the same slowness.

edit

Edited by Sanity, 08 February 2011 - 02:06 AM.


Can a team member please advise if the fixes suggested by foxp2 should be applied on all 2.3.1 shops as a rule?

I personally don't have the possibility of testing in an XP with IE8 environment so I don't know if I have the problem or not.

Could anyone share some advice please?

Thanks in advance.

Biancoblu, on 19 July 2011, 06:47, said:

I personally don't have the possibility of testing in an XP with IE8 environment so I don't know if I have the problem or not.
you can test with IE Tester software
or :
Internet Explorer Application Compatibility VPC Image

Edited by foxp2, 01 August 2011 - 09:04 AM.


Thanks for the links, I appreciate it  :thumbsup:

I have been searching for a solution to this too.
All the contents of page appear on screen quickly but the page seems to contiue trying to load for another 5-10 seconds so effectivly hangs (page can't scroll and links are not active)

OS = WINXP (home) & WINXP (pro)
BROWSER = IE8
SHOP VERSION = 2.3.1 -->VANILLA

This bug is on all pages in IE8
All pages in all other browsers I have tried load very well